New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652184 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Video in Fullscreen switches white point, shows green compression artifacts on white areas

Project Member Reported by drott@chromium.org, Oct 3 2016

Issue description

Version: 54.0.2840.41, also reproducible in Canary
OS: Mac

Mid 2014, Retina Macbook Pro 15 inch

What steps will reproduce the problem?
(1) Go to System Preferences, Display,
    Click calibrate and move the white point to the far left, to create a warmer profile for testing, then select the new profile.
(2) Go to Chrome, play this test color bar video https://www.youtube.com/watch?v=iYPuTv0F8XI in a loop
(3) Make the video fullscreen
(4) Move the mouse cursor away from the controls, wait until controls disappear.

Optional:
(5) Move the cursor to make the UI appear again an notice how it switches back.

What is the expected output?
Colors in the video stay stable

What do you see instead?
The white patch in the video suddenly swaps and video becomes colder in color.

But worse, in some videos with lesser compression quality, for examples videos where someone presents white slides, there are ugly green-ish artifacts on white areas.

I've tried to capture this in the attached video, recorded with a digital camera that was set to a fixed white balance option. 

You can notice the switching in the attached video at the ~9, 19 and 25 second marks.

I've tried to test this with a green/red swap ICC test profile, but I was not able to reproduce with that.

I believe this is a regression, I've been using a color profile on my laptop for a long while but did not usually see such glitches.

Same video plays with okay in Firefox, with color profile applied and no switching.
 
white_point_glitch_2.mp4
9.6 MB View Download
Cc: shrike@chromium.org ccameron@chromium.org
+ccameron who had CLs for color correction issues recently. Is this itself a regression from the latest changes?

drott: you don't say which macOS version you're using. There were changes in Sierra, so this is important. 

Comment 2 by drott@chromium.org, Oct 3 2016

Sorry, this was reproduced/filmed on 10.11.6 but reproducible on Sierra, too. 
Components: -Internals>Compositing
Cc: -hubbe@chromium.org
Labels: -Pri-1 Pri-3
Owner: hubbe@chromium.org
Status: Assigned (was: Untriaged)
hubbe@, can you take a look the recorded video in original post to see if this is a real bug? I am able to repro this issue. The color shade DOES change a bit when control bar hide away in full screen. But in any chance, I don't think this is a P1 bug. Change Pri to 3.

Comment 5 by drott@chromium.org, Oct 7 2016

As mentioned, on other videos, like presentations with mostly white slides, white patches seems to "color overflow" somehow and turn into an ugly green, the video becomes unbearable to watch and I switched browsers in this case.

This is related to the fact that we don't correctly set the color space parameters for non-h264 videos.

A short-term workaround is to install h264ify, which will enable the HW decoder to set these correctly.

It also appears that switching in and out of fullscreen low power mode alters color.

Comment 7 by drott@chromium.org, Oct 20 2016

Thanks for the analysis and workaround suggestion - are there any plans to fix this more generically?
Yes -- there's a lot of ongoing work for color correction.  Issue 622133  is tracking correction for video.

Comment 9 by hubbe@chromium.org, Oct 24 2016

Labels: -ReleaseBlock-Stable
Cc: hubbe@chromium.org
Owner: ccameron@chromium.org
I think this is fixed, assigning to ccameron to verify.

This works for me in Chrome 67, so I suspect that this is fixed now.

(We do correctly specify the color space for video frames' IOSurfaces, which was the root cause).

Comment 12 by drott@chromium.org, Mar 12 2018

Thanks for fixing, I did not see this reproducing anymore.

Comment 13 by drott@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)

Sign in to add a comment