New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

createElement should not transmit exceptions from custom element constructors

Project Member Reported by dominicc@chromium.org, Oct 3 2016

Issue description

Comment 1 by hayato@chromium.org, Oct 12 2016

Components: -Blink>WebComponents Blink>HTML>CustomElements
Hi Dominic,

If you are busy I can help with this one. As you said
option 1 from https://github.com/w3c/webcomponents/issues/569 looks good to try.
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21493ce8e12e552cd51c85523d451357bd427e1

commit a21493ce8e12e552cd51c85523d451357bd427e1
Author: dominicc <dominicc@chromium.org>
Date: Tue Oct 25 09:44:59 2016

createElement should not transmit exceptions but report them.

BUG= 652157 , 658066 

Review-Url: https://codereview.chromium.org/2443543002
Cr-Commit-Position: refs/heads/master@{#427306}

[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/construct.html
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/create-element-defined-synchronous.html
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/report-the-exception.html
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js
[delete] https://crrev.com/d3440cefcf916da441e0a3f417b6664ea5d0fd52/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/Document-createElement-expected.txt
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElement.h
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

Status: Fixed (was: Started)

Sign in to add a comment