New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652136 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

components_unittests failing on 4 builders

Project Member Reported by ksakamoto@chromium.org, Oct 3 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac

commit ad8dd0f5e2f12349dd418d0af919d0fd347c72ac
Author: ksakamoto <ksakamoto@chromium.org>
Date: Mon Oct 03 03:39:22 2016

Revert of [Sync] Move //components/sync to the syncer namespace. (patchset #5 id:40001 of https://codereview.chromium.org/2376123003 )

Reason for revert:
Speculative revert for components_unittests failures on debug builds,  https://crbug.com/652136 .

Original issue's description:
> [Sync] Move //components/sync to the syncer namespace.
>
> Things in components should live in namespaces that match their
> component. Unfortunately "sync" is a symbol defined in the std library,
> so in this case we are using "syncer".
>
> This CL does the following things inside //components/sync:
>
> - Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync with syncer.
> - Adds syncer namespace to some classes that were missing a namespace.
> - Removes almost all "syncer::" prefixes since they became redundant.
>
> Everything outside the component is just fixing namespace prefixes and forward declarations.
> I also fixed *some* lints, especially in headers outside of the component.
>
> This script was the starting point for this CL: http://pastebin.com/PPhPTtRK
>
> BUG= 646685 
> TBR=caitkp
>
> Committed: https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a
> Cr-Commit-Position: refs/heads/master@{#422239}

TBR=maxbogue@chromium.org
BUG= 646685 ,  652136 

Review-Url: https://codereview.chromium.org/2388673002
Cr-Commit-Position: refs/heads/master@{#422365}

[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/android/contextualsearch/contextual_search_delegate.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/android/foreign_session_helper.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/browsing_data/history_counter_browsertest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/chromeos/login/signin/auth_sync_observer.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/external_pref_loader.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/invalidation/profile_invalidation_provider_factory.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/chrome_sync_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_setting_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/extension_setting_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/theme_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/glue/theme_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_android.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_factory.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_test_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/profile_sync_test_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_ash.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_error_notifier_factory_ash.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error_factory.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_global_error_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_startup_tracker.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/sync_ui_util_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/migration_watcher.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/migration_watcher.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/p2p_sync_refresher.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync_file_system/sync_file_system_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/sync_file_system/sync_file_system_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/ash/app_sync_ui_state.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/avatar_button_error_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/sync/one_click_signin_sync_observer.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/browsing_history_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/foreign_session_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/browser_options_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/clear_browser_data_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/manage_profile_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/sync_setup_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/chrome/browser/ui/webui/sync_internals_ui.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/autofill_wallet_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/abstract_profile_sync_service_test.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_components_factory_impl.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/profile_sync_test_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/test_profile_sync_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browser_sync/test_profile_sync_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/counters/history_counter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/counters/history_counter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/history_notice_utils.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/history_notice_utils.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/browsing_data/core/history_notice_utils_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/history_delete_directives_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/history_delete_directives_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/typed_url_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/typed_url_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/history/core/browser/web_history_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/ntp_snippets/remote/ntp_snippets_test_utils.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/ntp_snippets/sessions/tab_delegate_sync_adapter.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/ntp_snippets/sessions/tab_delegate_sync_adapter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_bubble_experiment.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_bubble_experiment.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_bubble_experiment_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/core/browser/password_store_factory_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_manager_setting_migrator_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_manager_setting_migrator_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_sync_util.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_sync_util.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/password_sync_util_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/sync_credentials_filter.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/password_manager/sync/browser/sync_username_test_base.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/precache/content/precache_manager.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/precache/content/precache_manager.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/search_engine_data_type_controller.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/search_engine_data_type_controller.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/search_engine_data_type_controller_unittest.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/search_engines/template_url_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/suggestions/suggestions_service.cc
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d0fd347c72ac/components/suggestions/suggestions_service.h
[modify] https://crrev.com/ad8dd0f5e2f12349dd418d0af919d
Owner: ksakamoto@chromium.org
Status: Fixed (was: Available)
The tests are passing after the revert.

Sign in to add a comment