New issue
Advanced search Search tips

Issue 652132 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Poor alignment for SmartLock on login screen

Project Member Reported by reillyg@chromium.org, Oct 3 2016

Issue description

Version: 55.0.2869.0
OS: Chrome OS 8838.0.0

The icon indicating that SmartLock is currently checking whether it can log me in without a password is shifted too far to the right and moves the right arrow to a weird position in the middle of the password field. See screenshot.
 
IMG_20161003_104129.jpg
6.1 MB View Download
Owner: zalcorn@chromium.org
Status: Assigned (was: Untriaged)
Cc: alemate@chromium.org zalcorn@chromium.org
Owner: elizabethchiu@chromium.org
Elizabeth, is there an existing spec for how the arrow and smart lock icon are supposed to appear on startscreen/lockscreen? If not, could you create one?
Alex, this is fixed. https://bugs.chromium.org/p/chromium/issues/detail?id=646118  Not sure why the change is not implemented though. 
Cc: sammiequon@chromium.org
Sammie you fixed this for 54 right? Any idea why Albert is seeing it in 55?
Just want to follow up on this. Is this fixed?
It was supposed to be fixed for M54, but I haven't been able to reproduce it yet.
Owner: reillyg@chromium.org
I can't reproduce this on 54.0.2840.68 (Platform 8743.69.0), 55.0.2883.17 (Platform 88722.15.0), or 56.0.2899 (Platform 8929.0.0).
reillyg@, can you still reproduce this?
Tested on 55.0.2883.29. The login screen looks good but I noticed that during setup it looks like the password field is making room for the smart lock icon even though it shouldn't be displayed yet at that point. Screenshot attached.
IMG_20161104_080040.jpg
5.1 MB View Download
Owner: zalcorn@chromium.org
Cc: abodenha@chromium.org
Labels: PM-zalcorn
Owner: sammiequon@chromium.org
Hmm, that doesn't look right!
sammiequon@ could you take a look?
Hi,

I'm having a bit of trouble reproducing this. Are there any steps to make this happen? Thanks!
During the smart-lock setup flow the user is sent back to the login screen to enter their password. That is where screenshot in #8 was taken.
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f906fcba5e48b07fc1e27783b5341115aa50bbb

commit 8f906fcba5e48b07fc1e27783b5341115aa50bbb
Author: sammiequon <sammiequon@chromium.org>
Date: Fri Dec 02 19:03:44 2016

cros: Smart unlock set-up had space for icon while none is show.

Changed smart unlock icon show to only show if it user pod icon id is valid. Tested with smart unlock setup and smart unlock usage.

R=xiyuan@chromium.org

TEST=none
BUG= 652132 

Review-Url: https://codereview.chromium.org/2548703002
Cr-Commit-Position: refs/heads/master@{#435984}

[modify] https://crrev.com/8f906fcba5e48b07fc1e27783b5341115aa50bbb/ui/login/account_picker/user_pod_row.js

Status: Fixed (was: Started)

Comment 16 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 17 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 19 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment