Rename some things from "webkit" to "blink" to reduce confusion. |
|||||||
Issue descriptionBlink was forked from WebKit in 2013; as of Oct, the Blink codebase in Chromium is in a state where sometimes the name "Blink" is used, and sometimes "WebKit" is used, for legacy reasons. In general, renaming is hard because: (1) names have to be changed everywhere at once, often in multiple repositories. (2) Renames often break things unpredictably. And there are so many names to change that it's very unrealistic to rename many things within a short time frame. The main benefit of renaming is to reduce confusion. Some things which I think could theoretically be renamed in Tools/Scripts are: - Directory names webkitpy, webkitruby - Script names run-webkit-tests, webkit-patch, check-webkit-style, debug-webkit-tests - Class names TestWebKitPort, WebKitFinder, WebKitPatch... - Method names in webkitpy/style: check_webkit_style_parser, check_webkit_style_configuration... - Methods in webkitpy/w3c/test_converter.py: convert_for_webkit, path_from_webkit_root... - Methods in WebKitFinder and others: webkit_base, path_from_webkit_base And in our CI system: - Master name "chromium.webkit", and builder names under that master - Step names webkit_tests, webkit_unit_tests, archive_webkit_tests_results Not to mention the thousands of occurrences of "webkit" in the blink Source directory, including prefixed CSS properties. ⛆ |
|
|
,
Oct 3 2016
Would it be useful to get some numbers and maybe generate some graphs to track progress?
,
Oct 3 2016
Hmm, that could be done, think probably isn't worth spending much time on, but I still wanted to file a bug to track any related CLs. One of the more important renamings of course is bug 622551 (move third_party/WebKit to blink/). (Thanks Kent :-D) Just to make a quick note of the current count of the string "webkit": $ for f in *; do test -d $f && echo $f $(grep -ri webkit $f | wc -l); done LayoutTests 22662 ManualTests 560 PerformanceTests 281 public 110 Source 4834 Tools 1583
,
Oct 10 2016
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/875d3429c3fc94e129a39b28fad4a35a3913ee96 commit 875d3429c3fc94e129a39b28fad4a35a3913ee96 Author: qyearsley <qyearsley@chromium.org> Date: Fri Oct 28 02:09:46 2016 Rename _webkit_baseline_path -> _absolute_baseline_path. This is a minor renaming CL to clarify the purpose of this function. BUG= 652114 Review-Url: https://codereview.chromium.org/2455883004 Cr-Commit-Position: refs/heads/master@{#428240} [modify] https://crrev.com/875d3429c3fc94e129a39b28fad4a35a3913ee96/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py [modify] https://crrev.com/875d3429c3fc94e129a39b28fad4a35a3913ee96/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py [modify] https://crrev.com/875d3429c3fc94e129a39b28fad4a35a3913ee96/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py [modify] https://crrev.com/875d3429c3fc94e129a39b28fad4a35a3913ee96/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server.py
,
Nov 14 2016
In https://codereview.chromium.org/2496063002/, Dirk noted: I think using "blink_base" to refer to third_party/WebKit is probably confusing to most Blink devs, particularly since there is also a (mostly empty) //blink directory. In general, many of these changes would make more sense after moving third_party/WebKit to blink/ (bug 622551).
,
Apr 7 2017
,
Aug 16 2017
|
||||
►
Sign in to add a comment |
|||||||
Comment 1 by tkent@chromium.org
, Oct 2 2016Components: -Blink Blink>Infra Blink>Internals