Add disable switch for GpuMemoryBuffer backed VideoFrames in media streams |
|||||
Issue descriptionGpuMemoryBuffer backed VideoFrames in media streams caused some problems, see https://buganizer.corp.google.com/issues/31390397. Media thread gets stuck in a loop and frames keep being posted on it, which increases memory usage. In order to disable this feature while addressing these issues, we need a control switch.
,
Oct 3 2016
,
Oct 3 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92b9d47c220dee10de0f74f0b763b092d72f18bc commit 92b9d47c220dee10de0f74f0b763b092d72f18bc Author: emircan <emircan@chromium.org> Date: Mon Oct 03 18:37:39 2016 Disable GpuMemoryBuffer backed VideoFrames in media streams This CL adds a switch so that GpuMemoryBuffer backed VideoFrames can be turned off specifically for WebRTC use case. BUG= 652068 Review-Url: https://codereview.chromium.org/2386693004 Cr-Commit-Position: refs/heads/master@{#422329} (cherry picked from commit 704feb5ec21570eb28ae918cc8ff734f5da5082f) NOTRY=true NOPRESUBMIT=true TBR=tommi@chromium.org,dcastagna@chromium.org,avi@chromium.org Review-Url: https://codereview.chromium.org/2384223002 Cr-Commit-Position: refs/branch-heads/2840@{#624} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/92b9d47c220dee10de0f74f0b763b092d72f18bc/content/public/common/content_features.cc [modify] https://crrev.com/92b9d47c220dee10de0f74f0b763b092d72f18bc/content/public/common/content_features.h [modify] https://crrev.com/92b9d47c220dee10de0f74f0b763b092d72f18bc/content/renderer/media/media_stream_video_renderer_sink.cc
,
Oct 5 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92b9d47c220dee10de0f74f0b763b092d72f18bc commit 92b9d47c220dee10de0f74f0b763b092d72f18bc Author: emircan <emircan@chromium.org> Date: Mon Oct 03 18:37:39 2016 Disable GpuMemoryBuffer backed VideoFrames in media streams This CL adds a switch so that GpuMemoryBuffer backed VideoFrames can be turned off specifically for WebRTC use case. BUG= 652068 Review-Url: https://codereview.chromium.org/2386693004 Cr-Commit-Position: refs/heads/master@{#422329} (cherry picked from commit 704feb5ec21570eb28ae918cc8ff734f5da5082f) NOTRY=true NOPRESUBMIT=true TBR=tommi@chromium.org,dcastagna@chromium.org,avi@chromium.org Review-Url: https://codereview.chromium.org/2384223002 Cr-Commit-Position: refs/branch-heads/2840@{#624} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/92b9d47c220dee10de0f74f0b763b092d72f18bc/content/public/common/content_features.cc [modify] https://crrev.com/92b9d47c220dee10de0f74f0b763b092d72f18bc/content/public/common/content_features.h [modify] https://crrev.com/92b9d47c220dee10de0f74f0b763b092d72f18bc/content/renderer/media/media_stream_video_renderer_sink.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 1 2016