New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652032 link

Starred by 1 user
Status: Fixed
Owner:
█ mlliu@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ nyquist@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Blimp Client] Properly set the user agent for 0.6

Project Member Reported by dtrainor@chromium.org, Oct 1 2016 
Looks like BlimpClientContextImpl doesn't properly push the user agent to the engine.

- Move blimp/client/app/user_agent.* to blimp/client/core/settings/user_agent.*
- Have SettingsFeature::PushSettings() send a message with all relevant settings (including the generated user agent).

This should probably land after the settings refactor mlliu@ has in progress.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81

commit fb557601c87da27fcb8d2ed40d8f9fb9a5602b81
Author: mlliu <mlliu@chromium.org>
Date: Wed Nov 02 17:57:41 2016

Set the user agent for 0.6

This CL includes
- Move blimp/client/app/user_agent.* to
blimp/client/core/settings/user_agent.*
- Have SettingsFeature::PushSettings() send a message including the generated user agent.

BUG= 652032 

Review-Url: https://codereview.chromium.org/2473543002
Cr-Commit-Position: refs/heads/master@{#429335}

[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/app/BUILD.gn
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/app/session/blimp_client_session.cc
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/app/session/blimp_client_session.h
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/core/settings/BUILD.gn
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/core/settings/settings.cc
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/core/settings/settings_feature.cc
[modify] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/core/settings/settings_feature.h
[rename] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/core/settings/user_agent.cc
[rename] https://crrev.com/fb557601c87da27fcb8d2ed40d8f9fb9a5602b81/blimp/client/core/settings/user_agent.h

Comment 2 by mlliu@chromium.org, Nov 2 2016

Status: Fixed (was: Assigned)

Comment 3 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment