To see this dialog:

1. Navigate to www.sina.com
2. Click the blocked plugin icon in the omnibox
 

Per shrike, unassigning his Harmony bugs for now.

 Issue 682642  has been merged into this issue.

Assigning to Bret as I think he's seen some of the reviews go by for the (?) icon and other content settings refactoring here.

Before/after screenshots.

Deleted: before-preharmony.PNG 7.6 KB

	before-preharmony.PNG 7.6 KB View Download

Deleted: before-harmony.PNG 7.0 KB

	before-harmony.PNG 7.0 KB View Download

Deleted: after-preharmony.PNG 5.0 KB

	after-preharmony.PNG 5.0 KB View Download

Deleted: after-harmony.PNG 5.4 KB

	after-harmony.PNG 5.4 KB View Download

The NextAction date has arrived: 2017-09-29

The Harmony mock shows the Manage button next to the Done button, and the (?) button moved to the left edge of the dialog.

#15: We decided not to do that, because it would take the place of the Cancel button, and so the button order should be OS dependent which is weird for a "Manage" button. The alternative was to move the (?) button to the title, but that would be a huge pain since the code is mostly shared with other dialogs that don't have this problem.

Honestly I wish we could delete one button or the other.

Mocks are currently out-of-date for this section. Apologies for that. 

The after-harmony.png looks good, with one exception:

Flip the order of (?) and "Manage" so that (?) is the left-most icon. When there is no (?) icon, the manage button scoots over to the left-most position. 

Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d29f30d27128d92622f8579f84530a9a4c8cc10a

commit d29f30d27128d92622f8579f84530a9a4c8cc10a
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Oct 03 00:39:08 2017

Harmonize plugins blocked bubble.

Since Flash is now the only supported plugin, this patch removes all the
generic language in the dialog and makes it specific to Flash. This
patch also deletes some related strings that were unused.

Bug:  652030 
Change-Id: Iadd4eb43305f269456c59a06132c9d9c2184c6e3
Reviewed-on: https://chromium-review.googlesource.com/685806
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505888}
[modify] https://crrev.com/d29f30d27128d92622f8579f84530a9a4c8cc10a/chrome/app/generated_resources.grd
[modify] https://crrev.com/d29f30d27128d92622f8579f84530a9a4c8cc10a/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] https://crrev.com/d29f30d27128d92622f8579f84530a9a4c8cc10a/chrome/browser/content_settings/tab_specific_content_settings.h
[modify] https://crrev.com/d29f30d27128d92622f8579f84530a9a4c8cc10a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/d29f30d27128d92622f8579f84530a9a4c8cc10a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
[modify] https://crrev.com/d29f30d27128d92622f8579f84530a9a4c8cc10a/chrome/browser/ui/views/content_setting_bubble_contents.cc

Screenshot after flipping the button order.

This is ready for review.

Deleted: plugin-blocked-10.PNG 5.5 KB

	plugin-blocked-10.PNG 5.5 KB View Download

I cant trigger this through sina.com anymore but the screenshot lgtm.

The incorrect size and location of the 'X' on the puzzle piece icon is an unrelated bug I assume?

#21: Yes, I don't know what happened there. I'm guessing it's related to the force-device-scale-factor flag. In any case, I didn't touch it.