New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652028 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 630357


Participants' hotlists:
Harmony-Ready-For-Review


Sign in to add a comment

Harmony - update internal page info dialog

Project Member Reported by shrike@chromium.org, Oct 1 2016

Issue description

Comment 1 by shrike@chromium.org, Oct 11 2016

Owner: kylixrd@chromium.org

Comment 2 by shrike@chromium.org, Dec 14 2016

If you add a screenshot of this dialog as it exists now I can list the exact changes that need to be made to Harmonize it.

Comment 3 by tapted@chromium.org, Feb 13 2017

Cc: tapted@chromium.org
 Issue 691445  has been merged into this issue.

Comment 4 by tapted@chromium.org, Feb 14 2017

This is the end goal - we need to remove the icon and ensure padding is to spec.
Screen Shot 2017-02-14 at 5.19.45 pm.png
15.0 KB View Download

Comment 5 by tapted@chromium.org, Feb 14 2017

Cc: msrchandra@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 691912  has been merged into this issue.

Comment 6 by tapted@chromium.org, Feb 23 2017

Cc: spqc...@chromium.org shrike@chromium.org
 Issue 665385  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ba3aed77fb170397a571512cb60676cd4915a2

commit d7ba3aed77fb170397a571512cb60676cd4915a2
Author: kylixrd <kylixrd@chromium.org>
Date: Mon Mar 20 13:46:49 2017

Remove icon from internal page info dialog view in Material Design mode.

This should remove the icon according to the screen shot in the referenced issue.

BUG= 652028 

Review-Url: https://codereview.chromium.org/2750483003
Cr-Commit-Position: refs/heads/master@{#458054}

[modify] https://crrev.com/d7ba3aed77fb170397a571512cb60676cd4915a2/chrome/browser/ui/views/page_info/website_settings_popup_view.cc

Status: Fixed (was: Assigned)
Allen, did this trivial UI surface get final UX approval?  I want to make sure it's safe to cross off our spreadsheet.

Sign in to add a comment