MD Settings: wrong icon for protocol handlers in site settings |
|||||||||
Issue descriptionVersion: 55.0.2876.0 OS: 10.11 What steps will reproduce the problem? (1) Go to Settings (2) Expand the Advanced section (3) Click Site settings (4) Click Handlers What is the expected output? I expect to see the protocol handler icon (see attached) and be able to manage my protocol handler settings. What do you see instead? I see a different icon (see attached) and the Handlers screen only lets me prevent sites from asking to become handlers. I cannot, for example, see the list of sites that I've granted the handler privilege to or revoke it (as I can in the old settings page). Please use labels and text to provide additional information.
,
Oct 3 2016
I don't quite understand this bug... When I open Protocol Handlers, I get a list of protocols and a list of sites underneath. The list is, I believe, functionally equivalent to the one found under the old settings where I can choose which one is default. PS. The icon requested was the open-with icon which is the one pictured in the 'actual' screenshot. See decision here: https://bugs.chromium.org/p/chromium/issues/detail?id=614277#c8 ...
,
Oct 3 2016
> I don't quite understand this bug... Nevermind - I see that clicking on the row takes me to the section that lets me manage the list. The problem is there's no indication that clicking the row does anything. > PS. The icon requested was the open-with icon which is the one pictured in the 'actual' screenshot. See decision here: Well it's not the same as the Omnibox icon? The icons should be the same.
,
Oct 3 2016
> The problem is there's no indication that clicking the row does anything. good thing this change to add right-facing arrows landed right in the nick of time, then! fwiw: there was a "cursor: pointer;" that made a micky-mouse glove hand show up for a while (but it's subtle and only noticeable on :hover)
,
Oct 4 2016
Let's update the settings icon to match the omnibox one. SVG Asset can be found here: https://drive.google.com/open?id=0B6x6iYCtKinEUnY4cVNFMWNyM1E The SVG doesn't have any embedded padding so I've included a spec to ensure that it's displayed accurately amongst the 20x20px icons in Md-Settings. LMK if you have any questions.
,
Oct 4 2016
,
Oct 4 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f72054f57d109136d3cb9ce4162f8793cbed8f commit e5f72054f57d109136d3cb9ce4162f8793cbed8f Author: dschuyler <dschuyler@chromium.org> Date: Wed Oct 05 23:04:00 2016 [MD settings] change protocol handler icon This CL adds a new protocol-handler icon and removes the open-with icon that was previously used for the protocol handler. BUG= 652025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2392163002 Cr-Commit-Position: refs/heads/master@{#423329} [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/images/arrow_right.svg [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/images/open_in_new.svg [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
,
Oct 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f72054f57d109136d3cb9ce4162f8793cbed8f commit e5f72054f57d109136d3cb9ce4162f8793cbed8f Author: dschuyler <dschuyler@chromium.org> Date: Wed Oct 05 23:04:00 2016 [MD settings] change protocol handler icon This CL adds a new protocol-handler icon and removes the open-with icon that was previously used for the protocol handler. BUG= 652025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2392163002 Cr-Commit-Position: refs/heads/master@{#423329} [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/images/arrow_right.svg [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/images/open_in_new.svg [modify] https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dbeam@chromium.org
, Oct 1 2016Owner: bettes@chromium.org