We also need to add a way to bring up this dialog easily.

If you add a screenshot of this dialog as it exists now I can list the exact changes that need to be made to Harmonize it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27885745a25ab23665dd420b6b9443e9b2171284

commit 27885745a25ab23665dd420b6b9443e9b2171284
Author: kylixrd <kylixrd@chromium.org>
Date: Fri Mar 17 15:33:33 2017

Harmony - update Chrome Cleanup tool prompt dialog.

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG= 652019 

Review-Url: https://codereview.chromium.org/2746223002
Cr-Commit-Position: refs/heads/master@{#457774}

[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/safe_browsing/srt_fetcher_win.cc
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/safe_browsing/srt_fetcher_win.h
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/ui/views/harmony/harmony_layout_delegate.h
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/ui/views/harmony/layout_delegate.cc
[modify] https://crrev.com/27885745a25ab23665dd420b6b9443e9b2171284/chrome/browser/ui/views/harmony/layout_delegate.h

Here is what, I think, is the current equivalent incarnation of the "Chrome clenaup" prompt dialog.

It looks pretty close to being "Harmonized". Although, it shouldn't have the close (X), right? It does in this slide deck https://docs.google.com/presentation/d/1QdPzmwXOtQ-xCi1PGnxJCQwsnzDCA2E4M4gKtXYY5MI/edit#slide=id.g1ea981e4c6_0_63. However, it's not consistent with the reasoning behind there not needing to be a close (X) on dialogs with a clear "Cancel" button. The "Restore Chrome settings?" dialog looks similar and has a Cancel button, but doesn't have the close (X).

Deleted: RemoveHarmfulSoftware.png 7.6 KB

	RemoveHarmfulSoftware.png 7.6 KB View Download

c8: 

Hi kylixrd@, correct it shouldn't have the close (x) when Harmonized. 

For Pre-Harmony launch for the feature, I did ask the team(+ftirelo@) to not remove the current close (x) yet in order to keep the Pre-Harmony consistency.

Please let me know if there's anything to clarify further. 

Thanks!

Our current working model for things like the close (X) is to remove them for both harmony & non-harmony. This is for simplicity. The reasoning for removing them remains the same regardless of the mode. It will also reduce the effort down the road once we've turned it on permanently and there is no longer a non-harmony mode.

+ csharp@, ftirelo@, bettes@

c#10: the current working model SGTM. Thanks for the rationale. 

The NextAction date has arrived: 2017-11-10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/458bfb8222dbc1330a492eba26be712d8face5db

commit 458bfb8222dbc1330a492eba26be712d8face5db
Author: Allen Bauer <kylixrd@chromium.org>
Date: Fri Nov 10 15:38:55 2017

Removed close (X) from Chrome cleaner dialog.

Bug:  652019 
Change-Id: I106b707a35aa212da1d53de3cdac966b25cefd22
Reviewed-on: https://chromium-review.googlesource.com/758624
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515558}
[modify] https://crrev.com/458bfb8222dbc1330a492eba26be712d8face5db/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/458bfb8222dbc1330a492eba26be712d8face5db/chrome/browser/ui/views/chrome_cleaner_dialog_win.h

What's left on this dialog?

Seems like this is ready for UX review? added it to Harmony-Ready-For-Review.

I've attached a screenshot of the current state, for reference.

To me it looks like the dialog is being snapped up to 512; it should probably be 448. But otherwise it looks fine.

Deleted: chrome-cleaner-dialog.PNG 9.0 KB

	chrome-cleaner-dialog.PNG 9.0 KB View Download

The 'details' button is suspect to me. Does it take you to chrome://settings or something? 

+ changing to 448 sgtm
+ move checkbox into the content area, below body copy and above buttons 

+ Width is now 448
+ Checkbox moved into the content area.
+ Details button goes to settings cleanup page

Deleted: ChromeCleanerDialog.png 7.2 KB

	ChromeCleanerDialog.png 7.2 KB View Download

Both Details and Remove will open the Settings page. Please make sure you take into account crbug.com/793381: once it's fully launched, the landing page will become chrome://settings/cleanup.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72324deb7266d33424dd28dac0511a867196fbb2

commit 72324deb7266d33424dd28dac0511a867196fbb2
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Jan 16 18:55:40 2018

In ChromeCleanerDialog, Moved check box to content area and adjusted to force width to 448.

Bug:  652019 
Change-Id: Id85498def543449c078392962eb7f89b6017709c
Reviewed-on: https://chromium-review.googlesource.com/865277
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529476}
[modify] https://crrev.com/72324deb7266d33424dd28dac0511a867196fbb2/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/72324deb7266d33424dd28dac0511a867196fbb2/chrome/browser/ui/views/chrome_cleaner_dialog_win.h

How is this now?

LGTM