New issue
Advanced search Search tips

Issue 652006 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Log warnings on loading apps in app_shell

Project Member Reported by michae...@chromium.org, Oct 1 2016

Issue description

Without the chrome://extensions page, there is no way to detect warnings when loading extensions (such as invalid permissions).

We can LOG(WARNING) the warnings from ShellExtensionSystem::LoadApp(). However, I'm seeing some bogus warnings here, like invalid manifest keys that are actually valid.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a525387e44b256f162626c25fa14dd199d9c4094

commit a525387e44b256f162626c25fa14dd199d9c4094
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Oct 04 00:36:12 2016

Move permissions manifest key to //extensions

Permissions are parsed in //extensions. Moving the manifset key to the
//extensions _manifest_features.json file would prevent app_shell from
warning about an unknown "permissions" key (if app_shell warnings were
printed).

BUG= 652006 
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2391763003
Cr-Commit-Position: refs/heads/master@{#422632}

[modify] https://crrev.com/a525387e44b256f162626c25fa14dd199d9c4094/chrome/common/extensions/api/_manifest_features.json
[modify] https://crrev.com/a525387e44b256f162626c25fa14dd199d9c4094/extensions/common/api/_manifest_features.json

Example warning message proposed for https://codereview.chromium.org/2390073002/:

[96490:96490:1003/183739:1658739220753:WARNING:shell_extension_system.cc(65)] Warnings loading extension at /usr/local/google/home/redacted/tiny-app:
  Unrecognized manifest key 'minimum_chrome_version'.
  Permission 'metricsPrivate' is unknown or URL pattern is malformed.
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f456fb7856dc567afa9acb31c51cf81793677f0

commit 6f456fb7856dc567afa9acb31c51cf81793677f0
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Oct 06 08:10:23 2016

Log app_shell warnings on loading apps

Extension warnings should be logged somewhere, since we don't have a
UI for them like the Extensions UI's "developer mode".

R=steel@chromium.org
BUG= 652006 

Review-Url: https://codereview.chromium.org/2390073002
Cr-Commit-Position: refs/heads/master@{#423473}

[modify] https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0/extensions/shell/browser/shell_extension_system.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f456fb7856dc567afa9acb31c51cf81793677f0

commit 6f456fb7856dc567afa9acb31c51cf81793677f0
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Oct 06 08:10:23 2016

Log app_shell warnings on loading apps

Extension warnings should be logged somewhere, since we don't have a
UI for them like the Extensions UI's "developer mode".

R=steel@chromium.org
BUG= 652006 

Review-Url: https://codereview.chromium.org/2390073002
Cr-Commit-Position: refs/heads/master@{#423473}

[modify] https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0/extensions/shell/browser/shell_extension_system.cc

Comment 7 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57
Components: Platform>Apps>Shell

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment