Issue 652005 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ nxia@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Fix http Authorization for Buildbucket.

Project Member Reported by nxia@chromium.org, Oct 1 2016

Issue description

1)The old GetAccessToken had an infinite recursion bug.
Fix it by using the retry_util.GenericRetry method.
2)The old http instance needed to run get_access_token each time when http.request is called.
Fix it by creating an AuthorizedHttp class and setting token in the init method. Only retry get_access_token when the http.request fails with a retriable response.status.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5c09fe1aa63eca94e69c38c2bbe68abd9b5376dc

commit 5c09fe1aa63eca94e69c38c2bbe68abd9b5376dc
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Sep 30 22:35:09 2016

Refactor and fix auth.Authorize.

1)The old GetAccessToken had an infinite recursion bug.
Fix it by using the retry_util.GenericRetry method.
2)The old http instance needed to run get_access_token each time when
http.request is called.
Fix it by creating an AuthorizedHttp class and setting token in the
init method. Only retry get_access_token when the http.request fails
with a retriable response.status.

BUG= chromium:652005 
TEST=unit_test

Change-Id: I32654e57c482fb4b96045bddbf9f8264eb42029d
Reviewed-on: https://chromium-review.googlesource.com/391223
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[add] https://crrev.com/5c09fe1aa63eca94e69c38c2bbe68abd9b5376dc/lib/auth_unittest.py
[modify] https://crrev.com/5c09fe1aa63eca94e69c38c2bbe68abd9b5376dc/lib/auth.py
[add] https://crrev.com/5c09fe1aa63eca94e69c38c2bbe68abd9b5376dc/lib/auth_unittest
[modify] https://crrev.com/5c09fe1aa63eca94e69c38c2bbe68abd9b5376dc/cbuildbot/buildbucket_lib.py