New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651991 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add "Show all, only animate non-secure" option for the Security Verbose Flag

Project Member Reported by spqc...@chromium.org, Sep 30 2016

Issue description

Add "Show all, only animate non-secure" option to the "Material Security Verbose" flag
 
Description: Show this description
Cc: lgar...@chromium.org f...@chromium.org k...@chromium.org ainslie@chromium.org emilyschechter@chromium.org est...@chromium.org
Labels: OS-Linux OS-Windows
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d52dccd7192814d740a8bae50fcd32eb00816ce4

commit d52dccd7192814d740a8bae50fcd32eb00816ce4
Author: spqchan <spqchan@chromium.org>
Date: Thu Oct 13 00:15:40 2016

[Material] Update Material Security Verbose Decoration Flag

- Removed "Material" from the flag's name
- Added the option "Show all, only animate nonsecure"
- Set the default flag value to "Show all, non-animated"

BUG= 651991 ,  649682 

Review-Url: https://codereview.chromium.org/2378623007
Cr-Commit-Position: refs/heads/master@{#424917}

[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/app/generated_resources.grd
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/about_flags.cc
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/common/chrome_switches.h
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/tools/metrics/histograms/histograms.xml

Now available on Canary. Please note that the flag has been split into two new flags:

Security Chip - Used to toggle the visibility
Security Chip Animation - Used to toggle the chip animation

Default value will be "Show all" and "No animation"
Status: Fixed (was: Started)

Sign in to add a comment