New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651984 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Oct 2016
Cc:
█ mariakho...@chromium.org
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Ensure start and end are printed to logcat for all tests runs (including crashes)

Project Member Reported by tedc...@chromium.org, Sep 30 2016 
While investigating flaky test failures:

Dashboard:
  https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk

Example failure:
  Test name: ExternalNavigationDelegateImplTest#testIsPackageSpecializedHandler_WithTargetPackage_Matching
  Failure example: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/builds/36330

Downloaded the logcat, did "grep testIsPackageSpecializedHandler_WithTargetPackage_Matching <LOGCAT_FILE>"

In this instance, there were two passes, one failure, one success.

By tying the printing to logcat to the test runner, crashes will result in start/finish message that are not bounded.

I think we should move printing the start and finished messages to the host process so it is not affected by crashing tests.

Testing to logcat can be done via:
adb shell log "Test are funsies!"

Observed behavior: 
Grep prints this:
I TestRunner: started: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: finished: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: passed: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: started: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)

Expected behavior: 
I TestRunner: started: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: finished: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: passed: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: started: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: finished: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)
I TestRunner: failed: testIsPackageSpecializedHandler_WithTargetPackage_Matching(org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImplTest)

Comment 1 by jbudorick@chromium.org, Sep 30 2016

Owner: jbudorick@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf32ac6c05d9c688aace9f9f7a94b912b29af6a

commit ddf32ac6c05d9c688aace9f9f7a94b912b29af6a
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Oct 05 00:14:15 2016

[Android] Log instr test start & end.

BUG= 651984 

Review-Url: https://codereview.chromium.org/2385673005
Cr-Commit-Position: refs/heads/master@{#423012}

[modify] https://crrev.com/ddf32ac6c05d9c688aace9f9f7a94b912b29af6a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

Comment 3 by jbudorick@chromium.org, Oct 5 2016 

w/ #2, TestRunner will still do what it has been doing -- that's on the Android side of things, not in chromium. However, we'll now also add

test_runner_py: START <test name>

test_runner_py: END <test name>

Comment 4 by mariakho...@chromium.org, Oct 5 2016

Status: Fixed (was: Started)
Thanks, John!
►

Sign in to add a comment