New issue
Advanced search Search tips

Issue 651981 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove switch kEnableWebRtcHWH264Encoding

Project Member Reported by braveyao@chromium.org, Sep 30 2016

Issue description

switches::kEnableWebRtcHWH264Encoding was added for extensions and can be used
without SW fallback, in cl https://codereview.chromium.org/453063002.
Now it's time to remove it. One reason is SW fallback is already ready for all 
desktop platforms. Another reason is after cl
https://codereview.chromium.org/2358683002/ is in position, the checking
to switches::kDisableWebRtcHWEncoding is having the same effect.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e2e63439209a92a85c0aca328f68d3abab9af2

commit 58e2e63439209a92a85c0aca328f68d3abab9af2
Author: braveyao <braveyao@chromium.org>
Date: Fri Oct 21 16:57:26 2016

Remove switch kEnableWebRtcHWH264Encoding

switches::kEnableWebRtcHWH264Encoding was added for
extensions and can be used before SW fallback is in place.
Now it's time to remove it since SW fallback is already
ready for all desktop platforms.
BTW: Another reason is after cl
https://codereview.chromium.org/2358683002/
has landed, the checking to switches::kDisableWebRtcHWEncoding
is having the same effect.

BUG= 651981 

Review-Url: https://chromiumcodereview.appspot.com/2428383005
Cr-Commit-Position: refs/heads/master@{#426820}

[modify] https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2/content/public/common/content_switches.cc
[modify] https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2/content/public/common/content_switches.h
[modify] https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2/content/renderer/media/gpu/rtc_video_encoder_factory.cc

Status: Fixed (was: Started)
[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?

Sign in to add a comment