Issue metadata
Sign in to add a comment
|
chromiumperfstats should use CBE instead of directly polling the master |
||||||||||||||||||||||
Issue descriptionDirectly polling the master adds a lot of load to an already overwhelmed master. CBE already has all the same amount of information, so it's just a net positive change. I'd be glad to make the change myself, I just don't know where the code is or anything.
,
Oct 6 2016
Annie said she knows where the code lives.
,
Oct 6 2016
It lives at https://github.com/catapult-project/catapult/tree/master/firefighter (Note: even though it's a github project, it uses rietveld instead of pull requests)
,
Oct 7 2016
Awesome. Uploaded https://codereview.chromium.org/2400053002
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0dbc2160e1d0db3515bfedd9d0b525e91ac831b commit e0dbc2160e1d0db3515bfedd9d0b525e91ac831b Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Oct 07 21:19:38 2016 Roll src/third_party/catapult/ 6e780f733..0a0e13e30 (3 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6e780f733643..0a0e13e30fe5 $ git log 6e780f733..0a0e13e30 --date=short --no-merges --format='%ad %ae %s' 2016-10-07 charliea [chrome model helper] Fix some nits left over from crrev.com/2389243002 2016-10-07 alexandermont Remove unnecessary semicolons 2016-10-07 martiniss Use CBE for firefighter BUG= 651975 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2400043003 Cr-Commit-Position: refs/heads/master@{#423967} [modify] https://crrev.com/e0dbc2160e1d0db3515bfedd9d0b525e91ac831b/DEPS
,
Feb 13 2017
,
Feb 13 2017
Hey Stephen, what needs to happen here and when do you plan to get around to doing this?
,
Feb 14 2017
Stephen has been experimenting with adding a tracing visualization to Swarming. I think we can deprecate chromiumperfstats when that is working and the bots are all on Swarming. So WontFix? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by martiniss@chromium.org
, Oct 6 2016