Open tabs from other devices are synced even after disabling "Open tabs" in the sync settings. |
||||
Issue descriptionENVIRONMENT and STATS Chrome: 55.2876.0 OS: Android REPRO STEPS 1. Sign in to Chrome on an Android device and a desktop. 2. Open few websites in different tabs in Chrome on both Android and on desktop. 3. On Android Chrome go to Settings menu > Recent tabs and make sure that all the tabs opened on desktop are displayed. 4. On desktop go to chrome://history and make sure that all the tabs opened on Android are displayed. 5. On Android go to sync settings and uncheck "Open tabs" data type and save settings. 6. On Android Chrome go to Settings menu > Recent tabs and observe that the desktop tabs are still displayed. 7. On desktop open a new tab and browse a different website which was never used before. 8. On Android Chrome check the recent tabs ACTUAL RESULTS Tab opened on desktop in step 7 is synced to Android and is displayed in the recent tabs page. EXPECTED RESULTS Open tabs from other syncing clients should not be synced and displayed in the recent tabs page. No content (even the previously synced tabs) should be displayed in the recent tabs page when "Open tabs" setting is disabled ADDITIONAL INFO Tabs opened on Android are not synced to desktop after disabling "Open tabs" in the settings. This is not a regression in Chrome dev, also reproduced in Chrome beta.
,
Sep 30 2016
Android's ForeignSessionHelper has a function called isTabSyncEnabled, but it's never used. That's probably the cause of the discrepancy. I think zea is right that we should centralize the logic of disabling recenttabs.
,
Oct 4 2016
,
Oct 4 2016
What's the correct behavior if, in the initial steps, we were to disable 'Open tabs' on the _desktop_ client instead. As long as the Android client still has 'Open tabs' enabled, should it still see the desktop's tabs?
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90380f52bb9fb0a6e833701cdfe38541b08a0265 commit 90380f52bb9fb0a6e833701cdfe38541b08a0265 Author: pnoland <pnoland@chromium.org> Date: Fri Oct 07 20:16:01 2016 [sync] Open tabs from other devices are shown after disabling "Open Tabs" Check the isTabSyncEnabled flag before fetching foreign sessions in ForeignSessionHelper BUG= 651972 R=peconn Review-Url: https://codereview.chromium.org/2389383007 Cr-Commit-Position: refs/heads/master@{#423951} [modify] https://crrev.com/90380f52bb9fb0a6e833701cdfe38541b08a0265/chrome/android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java
,
Oct 12 2016
,
Nov 7 2016
For posterity, the current behavior asked about in #4 is mostly handled already. If a client disabled "Open tabs", all other clients stop receiving SESSION data from this first client. This means that the last commit the first client sent out with SESSION data will remain still seem valid, and will be used by everyone else. At least until it ages out normally (~14 days).
,
Dec 21 2016
Verified in M 56.0.2924.23. This has been fixed in 56 but still repros in M55. Changing the label and closing the bug. |
||||
►
Sign in to add a comment |
||||
Comment 1 by zea@chromium.org
, Sep 30 2016Owner: pnoland@chromium.org
Status: Assigned (was: Untriaged)