ComponentUnpacker writes incorrect FP |
|||||
Issue descriptionThe component unpacker writes the component's previous fingerprint into the manifest.fingerprint file, rather than the current fingerprint. Most of the time this is empty and relatively harmless, but if the browser experiences two updates in the same uptime, it will cause issues for future diff updates.
,
Oct 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e5db035aabd894b433c7ebc4fbb9af525612083 commit 6e5db035aabd894b433c7ebc4fbb9af525612083 Author: waffles <waffles@chromium.org> Date: Sat Oct 01 02:15:16 2016 Use the new fingerprint during unpacking, not the old. BUG= 651971 Review-Url: https://codereview.chromium.org/2384873002 Cr-Commit-Position: refs/heads/master@{#422287} [modify] https://crrev.com/6e5db035aabd894b433c7ebc4fbb9af525612083/components/update_client/action_update.cc
,
Oct 3 2016
,
Oct 3 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b889d6241b74018169c249e98962ef687083f980 commit b889d6241b74018169c249e98962ef687083f980 Author: Joshua Pawlicki <waffles@google.com> Date: Mon Oct 03 18:08:15 2016 Use the new fingerprint during unpacking, not the old. BUG= 651971 Review-Url: https://codereview.chromium.org/2384873002 Cr-Commit-Position: refs/heads/master@{#422287} (cherry picked from commit 6e5db035aabd894b433c7ebc4fbb9af525612083) Review URL: https://codereview.chromium.org/2385263002 . Cr-Commit-Position: refs/branch-heads/2840@{#622} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b889d6241b74018169c249e98962ef687083f980/components/update_client/action_update.cc
,
Oct 3 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b889d6241b74018169c249e98962ef687083f980 commit b889d6241b74018169c249e98962ef687083f980 Author: Joshua Pawlicki <waffles@google.com> Date: Mon Oct 03 18:08:15 2016 Use the new fingerprint during unpacking, not the old. BUG= 651971 Review-Url: https://codereview.chromium.org/2384873002 Cr-Commit-Position: refs/heads/master@{#422287} (cherry picked from commit 6e5db035aabd894b433c7ebc4fbb9af525612083) Review URL: https://codereview.chromium.org/2385263002 . Cr-Commit-Position: refs/branch-heads/2840@{#622} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b889d6241b74018169c249e98962ef687083f980/components/update_client/action_update.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by waff...@chromium.org
, Sep 30 2016Components: Internals>Installer>Components
Labels: M-55 OS-All
Owner: waff...@chromium.org
Status: Started (was: Untriaged)