New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651969 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ChromeLauncherControllerArcDefaultAppsTest.DefaultApps fails when running locally with filter

Project Member Reported by osh...@chromium.org, Sep 30 2016

Issue description

I haven't looked into details, but it's been failing when testing my CL and realized that it fails w/o my CL.

khmel@, can you look into this?

Fails when running single test
[ RUN      ] ChromeLauncherControllerArcDefaultAppsTest.DefaultApps
[18093:18093:0930/144653:7444155556409:ERROR:arc_bridge_service.cc(42)] ArcBridgeService is not ready.
[18093:18093:0930/144653:7444155558277:ERROR:arc_auth_service.cc(273)] Required ARC user data wipe failed.
[18093:18093:0930/144653:7444155653007:ERROR:arc_auth_service.cc(273)] Required ARC user data wipe failed.
../../../../../../../google2/home/oshima/chrome-git/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:3890: Failure
Value of: prefs->GetAppIds().size()
  Actual: false
Expected: true
[  FAILED  ] ChromeLauncherControllerArcDefaultAppsTest.DefaultApps (610 ms)


Crashes with running with --gtest_filter=ChromeLauncher*

Received signal 11 <unknown> 000000000000
#0 0x7f5a01f7129e base::debug::StackTrace::StackTrace()
#1 0x7f5a01f70ddf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f5a04ff0330 <unknown>
#3 0x000003775787 arc::ArcAuthService::OnSyncedPrefChanged()
#4 0x000003774acf arc::ArcAuthService::OnOptInPreferenceChanged()
#5 0x00000134096e _ZN4base8internal13FunctorTraitsIMNS_18CancelableCallbackIFvvEEEKFvvEvE6InvokeIRKNS_7WeakPtrIS4_EEJEEEvS6_OT_DpOT0_
#6 0x0000028f01ca _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN10extensions14ProcessManagerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#7 0x00000377fee2 _ZN4base8internal7InvokerINS0_9BindStateIMN3arc14ArcAuthServiceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#8 0x00000377fe2c _ZN4base8internal7InvokerINS0_9BindStateIMN3arc14ArcAuthServiceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x7f5a00f3cfdb base::internal::RunMixin<>::Run()
#10 0x7f5a00f48f3c PrefChangeRegistrar::InvokeUnnamedCallback()
#11 0x7f5a00f4a3df _ZN4base8internal13FunctorTraitsIPFvRKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEERKSsEvE6InvokeIJS8_SA_EEEvSC_DpOT_
#12 0x7f5a00f4a36d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEERKSsEJSA_SC_EEEvOT_DpOT0_
#13 0x7f5a00f4a317 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEERKSsEJS7_EEEFvSB_EE7RunImplIRKSD_RKSt5tupleIJS7_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEESB_
#14 0x7f5a00f4a24c _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEERKSsEJS7_EEEFvSB_EE3RunEPNS0_13BindStateBaseESB_
#15 0x7f5a00f49ed6 base::internal::RunMixin<>::Run()
#16 0x7f5a00f492d5 PrefChangeRegistrar::OnPreferenceChanged()
#17 0x7f5a00f51538 PrefNotifierImpl::FireObservers()
#18 0x7f5a00f5112f PrefNotifierImpl::OnPreferenceChanged()
#19 0x7f5a00f6e21d PrefValueStore::NotifyPrefChanged()
#20 0x7f5a00f6d7e3 PrefValueStore::OnPrefValueChanged()
#21 0x7f5a00f6d7b4 PrefValueStore::PrefStoreKeeper::OnPrefValueChanged()
#22 0x000008832577 TestingPrefStore::NotifyPrefValueChanged()
#23 0x0000088324f6 TestingPrefStore::SetValue()
#24 0x7f5a00f615ba PrefService::SetUserPrefValue()
#25 0x7f5a00f61662 PrefService::SetBoolean()
#26 0x000003777006 arc::ArcAuthService::DisableArc()
#27 0x000001aaf5cf ChromeLauncherControllerImplTest::EnableArc()
#28 0x000001aa983a ChromeLauncherControllerArcDefaultAppsTest_DefaultApps_Test::TestBody()
#29 0x00000194fe0a _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateESt5tupleIJEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS8_KFS3_vEEES3_PT_T0_RKS5_
#30 0x0000047d3cfe testing::internal::HandleExceptionsInMethodIfSupported<>()
#31 0x0000047c90f5 testing::Test::Run()
#32 0x0000047c9818 testing::TestInfo::Run()

 

Comment 1 by khmel@chromium.org, Sep 30 2016

Status: Started (was: Assigned)
will do, it seems currently flaky,

Thanks for reporting
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408ec0eb747b66fb0951e845c155c8ec2f20bb35

commit 408ec0eb747b66fb0951e845c155c8ec2f20bb35
Author: khmel <khmel@chromium.org>
Date: Mon Oct 03 21:06:13 2016

arc: Fix DefaultApps flakiness

This stabilizes ChromeLauncherControllerArcDefaultAppsTest.
DefaultApps when it gets executed in batch mode.

TEST=Multiple runs of unit_tests showed no retries for this test.
TEST= out/Debug/unit_tests --gtest_filter=*ChromeLauncherController*.
BUG= 651969 

Review-Url: https://codereview.chromium.org/2385223004
Cr-Commit-Position: refs/heads/master@{#422528}

[modify] https://crrev.com/408ec0eb747b66fb0951e845c155c8ec2f20bb35/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 3 by khmel@chromium.org, Oct 3 2016

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment