New issue
Advanced search Search tips

Issue 651965 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unittests for AIA fetching

Project Member Reported by mattm@chromium.org, Sep 30 2016

Issue description

We currently only have unittests for AIA cert fetching on NSS platforms. We should have them on other platforms as well, to avoid issues like 
 issue 645629 .

This should be possible by extending the minica.py code in SpawnedTestServer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fff06067760baa7539a6b4dfd6bb9e203e3c23fe

commit fff06067760baa7539a6b4dfd6bb9e203e3c23fe
Author: mattm <mattm@chromium.org>
Date: Tue Nov 29 00:19:04 2016

Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc.

Also use ScopedTestRoot instead of TestRootCerts::Add.

BUG= 651965 

Review-Url: https://codereview.chromium.org/2513543003
Cr-Commit-Position: refs/heads/master@{#434795}

[modify] https://crrev.com/fff06067760baa7539a6b4dfd6bb9e203e3c23fe/chrome/browser/chromeos/login/test/https_forwarder.cc
[modify] https://crrev.com/fff06067760baa7539a6b4dfd6bb9e203e3c23fe/chrome/browser/chromeos/login/test/https_forwarder.h

Comment 3 by mattm@chromium.org, Nov 29 2016

Status: Fixed (was: Started)

Sign in to add a comment