New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651964 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Traveling - Back 2/6
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Migrate Blimp Android Client to 0.6 APIs

Project Member Reported by nyquist@chromium.org, Sep 30 2016

Issue description

Similarly to  issue 645202  we also want to move the Android client to use the new public APIs.

This should in practice remove all dependencies of //blimp/client/app on //blimp/client/core, and it should instead use //blimp/client/public and //blimp/client/support.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce09cbb95446995ca12230ccf86b3467d0259f1

commit 1ce09cbb95446995ca12230ccf86b3467d0259f1
Author: nyquist <nyquist@chromium.org>
Date: Fri Oct 07 09:38:59 2016

Move session into //blimp/client/app and update GN files.

As part of making the Android Blimp APK compatible with the
//blimp/client/public APIs, this first CL moves the session code into
//blimp/client/app. This includes the GN-targets to ensure that they are
easily identifiable as belonging to the app directory.

This moves the APK-target itself, which means that the testing bots
needed to be updated with the new path to the target. In addition, the
lint suppressions needed to be updated with a new path.

The //blimp/client:blimp_unittests_java_deps (moved from //blimp), still
needs to be referred to directly by //blimp/BUILD.gn, because adding it
as a deps to //blimp/client:unit_tests on the Android platform does not
make the Java classes end up in the unit test APK. Other than this, the
rest of the targets have now been moved to //blimp/client and
//blimp/client/app.

Some targets have been renamed since they now reside in the app
directory.

Lastly, since the visibility parts of //blimp/client/core is cleaned up,
a bug was also filed for removing the visibility for internal core
targets for the engine browser tests.

BUG= 651964 ,  653789 

Review-Url: https://codereview.chromium.org/2387813002
Cr-Commit-Position: refs/heads/master@{#423825}

[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/BUILD.gn
[add] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/linux/blimp_client_session_linux.h
[rename] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/session/blimp_client_session.cc
[rename] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/session/blimp_client_session.h
[rename] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/session/test_client_session.cc
[rename] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/app/session/test_client_session.h
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/common/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/compositor/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/context/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/geolocation/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/input/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/render_widget/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/session/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/settings/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/client/core/switches/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/engine/BUILD.gn
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/engine/browser_tests/input_browsertest.cc
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/blimp/engine/browser_tests/navigation_browsertest.cc
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/build/android/lint/suppressions.xml
[modify] https://crrev.com/1ce09cbb95446995ca12230ccf86b3467d0259f1/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d4d7a54a39b017222ce964baaf8431f4453a957

commit 7d4d7a54a39b017222ce964baaf8431f4453a957
Author: xingliu <xingliu@chromium.org>
Date: Fri Nov 11 03:42:57 2016

Setup Blimp internal string resources.

Previously the 0.6 Chrome/Blimp integrated build still use strings in
//blimp/client/app, which also only generates android strings files.

This CL:
1. Setup strings resources in //blimp/client/core, all core code won't
use app resources anymore.

2. Internal core strings are protected behind the build flag
|enable_blimp_client|, so normal Chrome build won't contain Blimp
internal strings. Also the build flag is only used in
//blimp/client/core build files.

3. The Blimp linux shell only loads the English string pak file. Unit
tests and 0.5 app currently don't depends on the new core strings.

Clean resources bug.
BUG= 630687 

Decouple app and core code bug.
BUG= 651964 

Review-Url: https://codereview.chromium.org/2431653004
Cr-Commit-Position: refs/heads/master@{#431484}

[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/DEPS
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/blimp_startup.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/blimp_startup.h
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/linux/blimp_client_context_delegate_linux.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeHelperDialog.java
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/WebInputConfirmationPanel.java
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/BUILD.gn
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/drawable/dotted_line.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/layout/text_input_popup.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/layout/web_input_bottom_panel.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/values/arrays.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/values/colors.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/values/dimens.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/android/java/res/xml/blimp_preferences.xml
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/blimp_strings.cc
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/blimp_strings.grd
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/dummy_blimp_strings.cc
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/dummy_blimp_strings.grd
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_am.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ar.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_bg.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ca.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_cs.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_da.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_de.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_el.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_en-GB.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_es-419.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_es.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fa.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fi.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fil.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_fr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_hi.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_hr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_hu.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_id.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_it.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_iw.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ja.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ko.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_lt.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_lv.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_nl.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_no.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_pl.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_pt-BR.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_pt-PT.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ro.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_ru.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sk.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sl.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sv.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_sw.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_th.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_tr.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_uk.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_vi.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_zh-CN.xtb
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/resources/translations/blimp_strings_zh-TW.xtb
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/settings/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/BUILD.gn
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/blimp_client_context_delegate.h
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/resources/BUILD.gn
[add] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/blimp/client/public/resources/blimp_strings.h
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/build/android/lint/suppressions.xml
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/tools/gritsettings/resource_ids
[modify] https://crrev.com/7d4d7a54a39b017222ce964baaf8431f4453a957/tools/gritsettings/translation_expectations.pyl

Comment 3 by w...@chromium.org, Nov 12 2016

Status: Started (was: Untriaged)
Tommy, is this still in-progress?
yeah. I'm on it.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4494b26d5714a9492be7de380ba8012513d8f2ee

commit 4494b26d5714a9492be7de380ba8012513d8f2ee
Author: nyquist <nyquist@chromium.org>
Date: Mon Nov 14 23:52:42 2016

Move Java Blimp shell code to app subpackage

- Moves org.chromium.blimp app code to org.chromium.blimp.app.
- Moved org.chromium.blimp resources to org.chromium.blimp.app.R
- Renames BlimpView to BlimpContentsDisplay
- Formats all edited code.

BUG= 651964 

Review-Url: https://codereview.chromium.org/2493333002
Cr-Commit-Position: refs/heads/master@{#431989}

[modify] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/BUILD.gn
[modify] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/AndroidManifest.xml.jinja2
[modify] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/blimp_app_jni_registrar.cc
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/blimp_contents_display.cc
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/blimp_contents_display.h
[modify] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/res/layout/blimp_main.xml
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpApplication.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpContentsDisplay.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpLibraryLoader.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpRendererActivity.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/BrowserRestartActivity.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/auth/RetryingTokenSource.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/auth/TokenSource.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/auth/TokenSourceImpl.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/preferences/PreferencesUtil.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/session/BlimpClientSession.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/session/EngineInfo.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/session/TabControlFeature.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/settings/AboutBlimpPreferences.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/settings/Preferences.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/Toolbar.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/ToolbarMenu.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/UrlBar.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/javatests/src/org/chromium/blimp/app/BlimpNativeInstrumentationTestCase.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/javatests/src/org/chromium/blimp/app/auth/MockTokenSource.java
[rename] https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee/blimp/client/app/android/javatests/src/org/chromium/blimp/app/auth/RetryingTokenSourceTest.java

Status: WontFix (was: Started)
Obsolete, WontFix.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1fc2100ab3291b7a5852786ae55be932b688cce

commit a1fc2100ab3291b7a5852786ae55be932b688cce
Author: nyquist <nyquist@chromium.org>
Date: Tue Dec 06 04:36:40 2016

Make //blimp/client/app a real embedder of //blimp/client/public

While making //chrome embed //blimp using //blimp/client/public, the
Blimp shell APK was kept compiling and working, but still using the
internal APIs of the new code in //blimp/client/core.

This CL updates the Blimp shell APK code in //blimp/client/app to
use the new public API, which was the initial goal to eventually do.

As part of this, a new class was added to store all the member
global members that need to be kept alive; the BlimpEnvironment.

In addition, a new delegate for the BlimpClientContext was created,
that basically just logs everything all messages, and uses the
embedder support library to provide functionality like an
IdentityProvider.

The business logic changes mainly happen in BlimpRendererActivity,
the toolbar, and the BlimpContentsDisplay, in addition to a
the new preferences framework which mimics the one from //chrome.

This made it possible to delete a lot of old code and resources,
which is also done in this CL, in addition to clean up all
unnecessary dependencies and visibility rules.

The BlimpClientSession and related test code was also moved to the
engine browser tests.

Since the enable_blimp_client GN argument is still around,
//blimp/client/public still does not link in the non-dummy core
code yet, so there are still direct dependencies on core from the
app directory. This may easily be removed if enable_blimp_client
is discontinued, and the public API links in the right code.

BUG= 651964 

Review-Url: https://codereview.chromium.org/2542083004
Cr-Commit-Position: refs/heads/master@{#436526}

[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/AndroidManifest.xml.jinja2
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/DEPS
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_app_jni_registrar.cc
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_client_context_delegate_android.cc
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_client_context_delegate_android.h
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/blimp_client_session_android.cc
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_contents_display.cc
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_contents_display.h
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_environment.cc
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/blimp_environment.h
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/drawable-hdpi/web_input_background.9.png
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/drawable-mdpi/web_input_background.9.png
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/drawable-xhdpi/web_input_background.9.png
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/drawable-xxhdpi/web_input_background.9.png
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/drawable-xxxhdpi/web_input_background.9.png
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/drawable/dotted_line.xml
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/res/layout/blimp_main.xml
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/layout/debug_stats_overlay.xml
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/layout/text_input_popup.xml
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/layout/web_input_bottom_panel.xml
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/values/arrays.xml
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/res/values/dimens.xml
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/res/xml/blimp_preferences.xml
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpContentsDisplay.java
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpEnvironment.java
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpRendererActivity.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/auth/RetryingTokenSource.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/auth/TokenSource.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/auth/TokenSourceImpl.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/preferences/PreferencesUtil.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/session/BlimpClientSession.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/session/EngineInfo.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/session/TabControlFeature.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/java/src/org/chromium/blimp/app/settings/AboutBlimpPreferences.java
[add] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/settings/AppBlimpPreferenceScreen.java
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/settings/Preferences.java
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/Toolbar.java
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/ToolbarMenu.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/javatests/src/org/chromium/blimp/app/auth/MockTokenSource.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/javatests/src/org/chromium/blimp/app/auth/RetryingTokenSourceTest.java
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/tab_control_feature_android.cc
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/tab_control_feature_android.h
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/toolbar.cc
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/android/toolbar.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/blimp_startup.cc
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/blimp_startup.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/compositor/browser_compositor.cc
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/linux/blimp_client_session_linux.cc
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/app/linux/blimp_client_session_linux.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/common/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/compositor/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/compositor/blob_channel_feature.h
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/core/compositor/decoding_image_generator.cc
[delete] https://crrev.com/3a2f73dc6b05a3bf396af6e8fd3cf8ec6952ad9e/blimp/client/core/compositor/decoding_image_generator.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/context/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/geolocation/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/render_widget/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/resources/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/session/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/settings/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/switches/BUILD.gn
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/switches/blimp_client_switches.cc
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/core/switches/blimp_client_switches.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/client/public/contents/blimp_contents.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/BUILD.gn
[rename] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/browser_tests/blimp_client_session.cc
[rename] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/browser_tests/blimp_client_session.h
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/browser_tests/input_browsertest.cc
[modify] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/browser_tests/navigation_browsertest.cc
[rename] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/browser_tests/test_client_session.cc
[rename] https://crrev.com/a1fc2100ab3291b7a5852786ae55be932b688cce/blimp/engine/browser_tests/test_client_session.h

Labels: Archive-Blimp

Sign in to add a comment