New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651939 link

Starred by 5 users

Issue metadata

Status: Verified
Merged: issue 638545
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Alt+Tab should be dismissed when pressing Ctrl+F5

Project Member Reported by varkha@chromium.org, Sep 30 2016

Issue description

Version: 55.0.2869.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Press (and hold) Alt+Tab
(2) Press Ctrl+F5 (Ctrl+Alt+F5 is an accelerator for window screenshot)
(3) Release all keys

What is the expected output?
Window screenshot is active, Alt+Tab view is dismissed.
   or:
Alt+Tab view active, Ctrl+F5 (and probably some other accelerators) is ignored.

What do you see instead?
Alt+Tab view is still on screen. Window screenshot is active (mouse move moves the activation on screen and clicking on a window captures that window's screenshot.
Need an additional press on Alt key to dismiss Alt+Tab view.

Note: screenshot of a window with a hover selector was introduced as part of work on  issue 481059  (https://codereview.chromium.org/1909873002).

I think this could be solved by either dismissing the Alt+Tab when Ctrl+F5 is pressed or, alternatively by ignoring additional accelerators while in Alt+Tab mode. I have a slight preference for the second choice.
 
++ Observation:

Another case of this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=638545. This issue might be dupe of 638545.

Comment 2 by varkha@chromium.org, Oct 11 2016

Mergedinto: 638545
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3be101d020da2ce8eb7c0ab7d92708b8d86acd95

commit 3be101d020da2ce8eb7c0ab7d92708b8d86acd95
Author: estade <estade@chromium.org>
Date: Fri Oct 14 15:25:59 2016

Fix partial screenshot/window screenshot when holding Alt+Tab.

Normal screenshot (i.e. whole desktop screenshot) already works
normally, although AFAIK it's impossible to trigger while showing
Alt+ since that modifies the screenshot type.

Partial and window screenshots take over mouse events without breaking
existing mouse captures, so Alt+Tab doesn't know it should close. Fix
this by explicitly breaking existing mouse captures when a screenshot
session starts.

BUG= 651939 

Review-Url: https://codereview.chromium.org/2393703002
Cr-Commit-Position: refs/heads/master@{#425328}

[modify] https://crrev.com/3be101d020da2ce8eb7c0ab7d92708b8d86acd95/ash/utility/screenshot_controller.cc
[modify] https://crrev.com/3be101d020da2ce8eb7c0ab7d92708b8d86acd95/ash/utility/screenshot_controller_unittest.cc

Status: Fixed (was: Duplicate)
Cc: est...@chromium.org durga.behera@chromium.org krishna...@chromium.org brajkumar@chromium.org songsuk@chromium.org ajha@chromium.org kavvaru@chromium.org
 Issue 638545  has been merged into this issue.
Status: Assigned (was: Fixed)
Tested with Version 
With the repro steps:- 
(1) Press (and hold) Alt+Tab
(2) Press Ctrl+F5 (Ctrl+Alt+F5 is an accelerator for window screenshot)
(3) Release all keys

The Alt+tab window gets into continuous loop as attached video unable to dismiss it have to press esc key.


IMG_7307.MOV
637 KB Download

Comment 7 by varkha@chromium.org, Jan 26 2017

 Issue 663574  has been merged into this issue.
Labels: -Hotlist-Polish -M-55 -Pri-3 M-57 Pri-2
Let's target m-57 for the time being, but if I understand the issue correctly it would be pretty rare for end users to encounter this, and even if they do, the loop can be dismissed with Esc.
Labels: -M-57 M-58
Status: Fixed (was: Assigned)
I fixed this while fixing  bug 660945 , i.e. crrev.com/2080dad23aec7f5225154

I still don't think we should merge that fix though because as Terry points out, this is a pretty rare edge case and a non-critical failure mode (i.e. not a  crash), and I'd still be worried that patch breaks something else: window_cycle_event_filter_aura.cc references 4 bugs in less than 80 lines so it's fairly delicate.
Status: Verified (was: Fixed)
58.0.3007.0/9270.0.0

Sign in to add a comment