New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651937 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 651897



Sign in to add a comment

Consider removing DUMP_VIDEO and TEST_REAL_CAPTURE_DEVICE from VideoCaptureHostTest

Project Member Reported by mcasas@chromium.org, Sep 30 2016

Issue description

Hello
I am new to chromium. I have upload a patch for this 
https://codereview.chromium.org/2392113004
Cc: preeti.n...@samsung.com
Owner: mcasas@chromium.org
Status: Assigned (was: Available)
Assigned to preeti.nayak@samsung.com (to be as placeholder).
Taking it over in https://codereview.chromium.org/2403533002/
since I had to clean up other parts of the code.

Comment 4 by mcasas@chromium.org, Oct 10 2016

Status: Fixed (was: Assigned)
Somehow the latest CL landed on Fri didn't hit this bug,
so for completion, I'm pasting it here:

commit	https://chromium.googlesource.com/chromium/src.git/+/fe85428bd742a61f78db005f980b15c219c4464d

author	mcasas <mcasas@chromium.org>	
Fri Oct 07 22:30:13 2016

VideoCaptureHostTest: simplify testing and remove unused code

This CL cleans up the VideoCaptureHostTest code:
- removes unused DUMP video support
- removes possibility of using real cameras (we
have content_browsertests and browser_tests for it)
- removes actual ShMem mapping and bookkeeping
in MockVideoCaptureHost, because is not needed
(we just need the ids).

BUG= 651897 ,  651937 
TEST=no new production code, just unittest cleanup.

Review-Url: https://codereview.chromium.org/2403533002
Cr-Commit-Position: refs/heads/master@{#423988}

content/browser/renderer_host/media/video_capture_host.cc[diff]
content/browser/renderer_host/media/video_capture_host_unittest.cc[diff]

[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?

Sign in to add a comment