Consider removing DUMP_VIDEO and TEST_REAL_CAPTURE_DEVICE from VideoCaptureHostTest |
|||
Issue descriptionBecause they are not used AFAIK, and dead code is a smell. https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/video_capture_host_unittest.cc?q=DUMP_VIDEO&sq=package:chromium&l=65&dr=C and https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/video_capture_host_unittest.cc?q=DUMP_VIDEO&sq=package:chromium&dr=C&l=68
,
Oct 5 2016
Assigned to preeti.nayak@samsung.com (to be as placeholder).
,
Oct 7 2016
Taking it over in https://codereview.chromium.org/2403533002/ since I had to clean up other parts of the code.
,
Oct 10 2016
Somehow the latest CL landed on Fri didn't hit this bug, so for completion, I'm pasting it here: commit https://chromium.googlesource.com/chromium/src.git/+/fe85428bd742a61f78db005f980b15c219c4464d author mcasas <mcasas@chromium.org> Fri Oct 07 22:30:13 2016 VideoCaptureHostTest: simplify testing and remove unused code This CL cleans up the VideoCaptureHostTest code: - removes unused DUMP video support - removes possibility of using real cameras (we have content_browsertests and browser_tests for it) - removes actual ShMem mapping and bookkeeping in MockVideoCaptureHost, because is not needed (we just need the ids). BUG= 651897 , 651937 TEST=no new production code, just unittest cleanup. Review-Url: https://codereview.chromium.org/2403533002 Cr-Commit-Position: refs/heads/master@{#423988} content/browser/renderer_host/media/video_capture_host.cc[diff] content/browser/renderer_host/media/video_capture_host_unittest.cc[diff]
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue? |
|||
►
Sign in to add a comment |
|||
Comment 1 by preeti.n...@samsung.com
, Oct 5 2016