New issue
Advanced search Search tips

Issue 651927 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: console shows timestamps for command results when it should not

Project Member Reported by l...@chromium.org, Sep 30 2016 
Version: 53

What steps will reproduce the problem?
(1) Open DevTools console, make some evaluations (e.g. type '1' and press enter)
(2) Open settings (F1) and check 'Enable timestamps'
(3) Close settings, and see that timestamps are next to every evaluated result
(4) Force an update by evaluating something new in the console

What is the expected output?
Either no timestamps should appear for any evaluations, or we should show them for any evaluation.

What do you see instead?
Timestamps appear for every evaluation after step (3).  After step (4), they disappear

Comment 1 by l...@chromium.org, Dec 6 2016

Labels: Hotlist-Polish
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d674aa2e6ff1a72c7a427ef033cc75e48cc61876

commit d674aa2e6ff1a72c7a427ef033cc75e48cc61876
Author: luoe <luoe@chromium.org>
Date: Mon Jan 30 21:17:11 2017

DevTools: update console timestamp style

A few bugs with console timestamps are addressed:
- All messages get timestamps; previously, commands/evaluations did not.
- Timestamps should not wrap
- Turning on timestamps should remove the repeated-message class
- New setting to choose [none, full timestamp, short timestamp (no yy:mm:dd)]

With the addition of a new setting, users who previously had timestamps enabled
will be migrated to the short format by default.

BUG= 651927 ,  678585 ,  682049 

Review-Url: https://codereview.chromium.org/2651843003
Cr-Commit-Position: refs/heads/master@{#447065}

[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp-expected.txt
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d674aa2e6ff1a72c7a427ef033cc75e48cc61876

commit d674aa2e6ff1a72c7a427ef033cc75e48cc61876
Author: luoe <luoe@chromium.org>
Date: Mon Jan 30 21:17:11 2017

DevTools: update console timestamp style

A few bugs with console timestamps are addressed:
- All messages get timestamps; previously, commands/evaluations did not.
- Timestamps should not wrap
- Turning on timestamps should remove the repeated-message class
- New setting to choose [none, full timestamp, short timestamp (no yy:mm:dd)]

With the addition of a new setting, users who previously had timestamps enabled
will be migrated to the short format by default.

BUG= 651927 ,  678585 ,  682049 

Review-Url: https://codereview.chromium.org/2651843003
Cr-Commit-Position: refs/heads/master@{#447065}

[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp-expected.txt
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d674aa2e6ff1a72c7a427ef033cc75e48cc61876

commit d674aa2e6ff1a72c7a427ef033cc75e48cc61876
Author: luoe <luoe@chromium.org>
Date: Mon Jan 30 21:17:11 2017

DevTools: update console timestamp style

A few bugs with console timestamps are addressed:
- All messages get timestamps; previously, commands/evaluations did not.
- Timestamps should not wrap
- Turning on timestamps should remove the repeated-message class
- New setting to choose [none, full timestamp, short timestamp (no yy:mm:dd)]

With the addition of a new setting, users who previously had timestamps enabled
will be migrated to the short format by default.

BUG= 651927 ,  678585 ,  682049 

Review-Url: https://codereview.chromium.org/2651843003
Cr-Commit-Position: refs/heads/master@{#447065}

[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp-expected.txt
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/platform/utilities.js

Comment 5 by l...@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment