New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651924 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
pav...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] Rename DataTypeState to ModelTypeState for consistency

Project Member Reported by maxbogue@chromium.org, Sep 30 2016 
DataTypeState is USS-only. Even though its fields will still be DataType*, we should rename it for consistency in the USS interfaces and terminology.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1832476ae0bfe131932de73f47214ec9b11946

commit bd1832476ae0bfe131932de73f47214ec9b11946
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Oct 04 22:17:38 2016

[Sync] Rename DataTypeState to ModelTypeState.

BUG= 651924 

Review-Url: https://codereview.chromium.org/2394573002
Cr-Commit-Position: refs/heads/master@{#422961}

[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/api/fake_model_type_service.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/api/fake_model_type_service.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/api/metadata_batch.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/api/metadata_batch.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/api/metadata_change_list.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/activation_context.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/model_type_processor.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/shared_model_type_processor.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/shared_model_type_processor.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/shared_model_type_processor_unittest.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/simple_metadata_change_list.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/simple_metadata_change_list.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/simple_metadata_change_list_unittest.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core/test/fake_model_type_processor.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/core_impl/test/fake_model_type_processor.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/device_info/device_info_service.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/device_info/device_info_service_unittest.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/engine_impl/model_type_registry.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/engine_impl/model_type_registry_unittest.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/engine_impl/model_type_worker.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/engine_impl/model_type_worker.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/engine_impl/model_type_worker_unittest.cc
[rename] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/protocol/model_type_state.proto
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/protocol/protocol_sources.gni
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/test/engine/mock_model_type_processor.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/test/engine/mock_model_type_processor.h
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/test/engine/mock_model_type_worker.cc
[modify] https://crrev.com/bd1832476ae0bfe131932de73f47214ec9b11946/components/sync/test/engine/mock_model_type_worker.h

Comment 2 by maxbogue@chromium.org, Oct 4 2016

Status: Fixed (was: Assigned)

Comment 3 by maxbogue@chromium.org, Oct 6 2016

Labels: Sync-Code-Health

Comment 4 by maxbogue@chromium.org, Oct 6 2016

Labels: -Sync-Code-Health Hotlist-CodeHealth
►

Sign in to add a comment