New issue
Advanced search Search tips

Issue 651917 link

Starred by 1 user
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Chrome not exposing font or language on all elements

Project Member Reported by dmazz...@chromium.org, Sep 30 2016 
User report:

1.      Open http://www.freedomscientific.com/
2.      Go to top of page.
3.      Pres r twice to go to navigation region.
4.      Arrow down to Products link.
5.      Press ins+f to get font info.
In Chrome the font is reported as Times New Roman. In IE it is Verdana. In Firefox there is no font info given on links though it is given correctly in other places on the page, eg headings. Chrome is still different on the headings. On the headings, Firefox and IE give the same font info.

The issue is happening when the element with the font change (or language change) is ignored.

Comment 1 by dmazz...@chromium.org, Sep 30 2016 

Here's how to reproduce a related issue with languages:

1.      Go to http://www.freedomscientific.com/Training/Surfs-Up/Languages.htm.
2.      Move down the page to the samples of text in different languages.
3.      In Firefox or IE, JAWS switches languages correctly. In Chrome it does not.
4.      When I look at the Accessibility tree, the elements with ROLE_SYSTEM_STATICTEXT containing the pieces of text have a language attribute in the accessibility tree  of language:en-US which is clearly incorrect.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571683bf6f39de12e3269fa493c68cc410602463

commit 571683bf6f39de12e3269fa493c68cc410602463
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Oct 05 22:28:19 2016

Fix issue with font family and language in accessibility tree

We were incorrectly not exposing the font family and language if the
change happened on a node that we happened to ignore in the
accessibility tree.

See related bug 651614 where I'm hoping to get rid of or at least simplify
the concept of "ignored" because it causes problems like this

BUG= 651917 

Review-Url: https://codereview.chromium.org/2382343002
Cr-Commit-Position: refs/heads/master@{#423316}

[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/renderer/accessibility/blink_ax_tree_source.cc
[add] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/font-family-expected-blink.txt
[add] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/font-family.html
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/language-expected-blink.txt
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/language-expected-win.txt
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/language.html

Comment 3 by dmazz...@chromium.org, Oct 13 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571683bf6f39de12e3269fa493c68cc410602463

commit 571683bf6f39de12e3269fa493c68cc410602463
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Oct 05 22:28:19 2016

Fix issue with font family and language in accessibility tree

We were incorrectly not exposing the font family and language if the
change happened on a node that we happened to ignore in the
accessibility tree.

See related bug 651614 where I'm hoping to get rid of or at least simplify
the concept of "ignored" because it causes problems like this

BUG= 651917 

Review-Url: https://codereview.chromium.org/2382343002
Cr-Commit-Position: refs/heads/master@{#423316}

[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/renderer/accessibility/blink_ax_tree_source.cc
[add] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/font-family-expected-blink.txt
[add] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/font-family.html
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/language-expected-blink.txt
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/language-expected-win.txt
[modify] https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463/content/test/data/accessibility/css/language.html

Comment 5 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment