New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651916 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Volume strength icon is not updated on volume control clicks

Project Member Reported by varkha@chromium.org, Sep 30 2016

Issue description

Version: 55.0.2869.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Open system menu
(2) Scroll volume to minimum
(3) Click the volume control near the loudest volume

What is the expected output?
Volume indicated by the speaker icon is high.

What do you see instead?
Volume indicated by the speaker icon is low.

See attached screenshot (notice no volume strength badging).
 
Screenshot 2016-09-30 at 15.43.17.png
1.6 KB View Download

Comment 1 by varkha@chromium.org, Sep 30 2016

This is the expected look after repro steps above.
Screenshot 2016-09-30 at 15.44.44.png
2.8 KB View Download

Comment 2 by varkha@chromium.org, Sep 30 2016

Cc: moh...@chromium.org
Possibly better to fix in conjunction with updating the volume icon from a PNG image map to vector icons (see issue 646537).
Cc: yiyix@chromium.org
Labels: -M-55 M-56
Owner: moh...@chromium.org
Mohsen, assigning this to you to take a look at in conjunction with issue 646537.
Owner: yiyix@chromium.org
Handing back to Yi to look at.
Labels: Pri-1
Cc: durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org kavvaru@chromium.org
 Issue 662813  has been merged into this issue.
Labels: -Type-Bug ReleaseBlock-Stable Type-Bug-Regression
As described in  issue 662813 , it looks like this is indeed a regression likely caused by something we changed when doing MD work.

Yi and Mohsen, likely suspects are either changes to the volume slider code or changes to how we're selecting / rendering the volume icons. Please take a look and see if you can figure out what's happening here.

Comment 9 by yiyix@chromium.org, Nov 11 2016

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/480579a68ad8f86bd7e7b0d798d515550644fd9c

commit 480579a68ad8f86bd7e7b0d798d515550644fd9c
Author: yiyix <yiyix@chromium.org>
Date: Sun Nov 13 22:55:33 2016

Fix the volume strength icon to reflect the volume control clicks

- When the thumb is dragged to the left, the volume strength icon still
shows that the audio is not muted. This bug is caused by the internal
audio state, which takes int only, is different from the slider volume
state, which takes floats only.

- When user clicks on volume control slider, the volume strength icon is not
updated accordingly. This is because the volume strength icon was not called
to update.

TEST=MANUAL
- Build the Chrome OS to an actual device and test if the bugs are fixed.

BUG=651930,  651916 

Review-Url: https://codereview.chromium.org/2485353002
Cr-Commit-Position: refs/heads/master@{#431811}

[modify] https://crrev.com/480579a68ad8f86bd7e7b0d798d515550644fd9c/ash/common/system/chromeos/audio/volume_view.cc
[modify] https://crrev.com/480579a68ad8f86bd7e7b0d798d515550644fd9c/ash/common/system/chromeos/audio/volume_view.h

Comment 11 by yiyix@chromium.org, Nov 14 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 9000.0.0, 56.0.2923.0

Sign in to add a comment