Issue metadata
Sign in to add a comment
|
Volume strength icon is not updated on volume control clicks |
||||||||||||||||||||||
Issue descriptionVersion: 55.0.2869.0 OS: Chrome OS What steps will reproduce the problem? (1) Open system menu (2) Scroll volume to minimum (3) Click the volume control near the loudest volume What is the expected output? Volume indicated by the speaker icon is high. What do you see instead? Volume indicated by the speaker icon is low. See attached screenshot (notice no volume strength badging).
,
Sep 30 2016
,
Sep 30 2016
Possibly better to fix in conjunction with updating the volume icon from a PNG image map to vector icons (see issue 646537).
,
Oct 7 2016
Mohsen, assigning this to you to take a look at in conjunction with issue 646537.
,
Oct 31 2016
Handing back to Yi to look at.
,
Nov 7 2016
,
Nov 9 2016
Issue 662813 has been merged into this issue.
,
Nov 9 2016
As described in issue 662813 , it looks like this is indeed a regression likely caused by something we changed when doing MD work. Yi and Mohsen, likely suspects are either changes to the volume slider code or changes to how we're selecting / rendering the volume icons. Please take a look and see if you can figure out what's happening here.
,
Nov 11 2016
,
Nov 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480579a68ad8f86bd7e7b0d798d515550644fd9c commit 480579a68ad8f86bd7e7b0d798d515550644fd9c Author: yiyix <yiyix@chromium.org> Date: Sun Nov 13 22:55:33 2016 Fix the volume strength icon to reflect the volume control clicks - When the thumb is dragged to the left, the volume strength icon still shows that the audio is not muted. This bug is caused by the internal audio state, which takes int only, is different from the slider volume state, which takes floats only. - When user clicks on volume control slider, the volume strength icon is not updated accordingly. This is because the volume strength icon was not called to update. TEST=MANUAL - Build the Chrome OS to an actual device and test if the bugs are fixed. BUG=651930, 651916 Review-Url: https://codereview.chromium.org/2485353002 Cr-Commit-Position: refs/heads/master@{#431811} [modify] https://crrev.com/480579a68ad8f86bd7e7b0d798d515550644fd9c/ash/common/system/chromeos/audio/volume_view.cc [modify] https://crrev.com/480579a68ad8f86bd7e7b0d798d515550644fd9c/ash/common/system/chromeos/audio/volume_view.h
,
Nov 14 2016
,
Nov 22 2016
Verified on ChromeOS 9000.0.0, 56.0.2923.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by varkha@chromium.org
, Sep 30 20162.8 KB
2.8 KB View Download