New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651903 link

Starred by 1 user
Status: Fixed
Owner:
█ joenotcharles@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
alito@chromium.org
█ rkaplow@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

SoftwareReporter.MemoryUsed has bad values in M54

Project Member Reported by joenotcharles@chromium.org, Sep 30 2016 
Version: M54
OS: all Windows

Due to a cut and paste error http://crrev.com/2278013002 changed SoftwareReporter.MemoryUsed from a regular count histogram to a linear histogram. As a result the values logged in M54 and later for this metric cannot be compared to values from earlier releases.

If this can be fixed before M54 goes to stable, we will have just a small amount of bad data from M54 and M55 which will be swamped by the amount of valid data received from stable M54, so we can get away without introducing a MemoryUsed2.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a82522ca23a533cf581ecb4d8b005c4d5cdfb77

commit 6a82522ca23a533cf581ecb4d8b005c4d5cdfb77
Author: joenotcharles <joenotcharles@chromium.org>
Date: Mon Oct 03 20:09:27 2016

SRTFetcher memory histograms should not use LinearHistogram.

BUG= 651903 

Review-Url: https://codereview.chromium.org/2388223002
Cr-Commit-Position: refs/heads/master@{#422507}

[modify] https://crrev.com/6a82522ca23a533cf581ecb4d8b005c4d5cdfb77/chrome/browser/safe_browsing/srt_fetcher_win.cc

Comment 2 by joenotcharles@chromium.org, Oct 5 2016

Labels: Merge-Request-54

Comment 3 by dimu@chromium.org, Oct 5 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 4 by bustamante@google.com, Oct 5 2016

Labels: -Merge-Review-54 Merge-Approved-54
This change meets the bar and is approved for M54
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ffd33643aa5485488674346ba28adbe983aced

commit 86ffd33643aa5485488674346ba28adbe983aced
Author: Cait Phillips <caitkp@chromium.org>
Date: Wed Oct 05 21:16:59 2016

SRTFetcher memory histograms should not use LinearHistogram.

BUG= 651903 

Review-Url: https://codereview.chromium.org/2388223002
Cr-Commit-Position: refs/heads/master@{#422507}
(cherry picked from commit 6a82522ca23a533cf581ecb4d8b005c4d5cdfb77)

Review URL: https://codereview.chromium.org/2396973002 .

Cr-Commit-Position: refs/branch-heads/2840@{#654}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/86ffd33643aa5485488674346ba28adbe983aced/chrome/browser/safe_browsing/srt_fetcher_win.cc

Comment 6 by joenotcharles@chromium.org, Oct 17 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ffd33643aa5485488674346ba28adbe983aced

commit 86ffd33643aa5485488674346ba28adbe983aced
Author: Cait Phillips <caitkp@chromium.org>
Date: Wed Oct 05 21:16:59 2016

SRTFetcher memory histograms should not use LinearHistogram.

BUG= 651903 

Review-Url: https://codereview.chromium.org/2388223002
Cr-Commit-Position: refs/heads/master@{#422507}
(cherry picked from commit 6a82522ca23a533cf581ecb4d8b005c4d5cdfb77)

Review URL: https://codereview.chromium.org/2396973002 .

Cr-Commit-Position: refs/branch-heads/2840@{#654}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/86ffd33643aa5485488674346ba28adbe983aced/chrome/browser/safe_browsing/srt_fetcher_win.cc
►

Sign in to add a comment