This requires extracting label and placeholder information associated with the input element and passing down to blimp.
Adding tracking bug and associated milestone.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aacf8d1d11beaff516bd79f88b8571eae0f5d031 commit aacf8d1d11beaff516bd79f88b8571eae0f5d031 Author: shaktisahu <shaktisahu@chromium.org> Date: Sat Nov 19 01:07:37 2016 Extracting placeholder information from Webkit to Blimp For text input, the new Blimp IME requires few additional information associated with the text field such as label and placeholder attributes. For a mock UI, visit go/blimp-type-3 In this CL, the Blimp tab makes a call to RenderFrameHost to access the information about the currently focused text input field and supplies a callback to act upon obtaining the information. The RenderFrame gets the information, populates it into a FormFieldData struct and passes it to the browser which then invokes the supplied callback by the embedder. BUG= 651902 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2370393002 Cr-Commit-Position: refs/heads/master@{#433364} [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/blimp/engine/feature/engine_render_widget_feature.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/blimp/engine/feature/engine_render_widget_feature.h [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/blimp/engine/feature/engine_render_widget_feature_unittest.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/blimp/engine/session/blimp_engine_session.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/blimp/engine/session/tab.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/blimp/engine/session/tab.h [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/common/frame_messages.h [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/public/browser/render_frame_host.h [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/public/common/BUILD.gn [add] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/public/common/form_field_data.cc [add] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/public/common/form_field_data.h [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/renderer/render_frame_impl.cc [modify] https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031/content/renderer/render_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa9428f0ee39451a7c8c4f1386d20949bede4320 commit fa9428f0ee39451a7c8c4f1386d20949bede4320 Author: dpranke <dpranke@chromium.org> Date: Sun Nov 20 22:27:26 2016 Revert of Extracting placeholder information from Webkit to Blimp (patchset #15 id:280001 of https://codereview.chromium.org/2370393002/ ) Reason for revert: I'm speculatively reverting this to see if it causes the failure in blink_platform_unittests noted in https://crbug.com/667094 and as seen in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20123 . It's not at all obvious to my why this would cause that failure, but it's not obvious to me what other changes would've, either, unless maybe it was pdr's change (which I will try if this doesn't fix it). Original issue's description: > Extracting placeholder information from Webkit to Blimp > > For text input, the new Blimp IME requires few additional information > associated with the text field such as label and placeholder attributes. > For a mock UI, visit go/blimp-type-3 > > In this CL, the Blimp tab makes a call to RenderFrameHost to access > the information about the currently focused text input field and > supplies a callback to act upon obtaining the information. The > RenderFrame gets the information, populates it into a FormFieldData > struct and passes it to the browser which then invokes the supplied > callback by the embedder. > > BUG= 651902 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031 > Cr-Commit-Position: refs/heads/master@{#433364} TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 651902 Review-Url: https://codereview.chromium.org/2513333002 Cr-Commit-Position: refs/heads/master@{#433460} [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/blimp/engine/feature/engine_render_widget_feature.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/blimp/engine/feature/engine_render_widget_feature.h [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/blimp/engine/feature/engine_render_widget_feature_unittest.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/blimp/engine/session/blimp_engine_session.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/blimp/engine/session/tab.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/blimp/engine/session/tab.h [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/common/frame_messages.h [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/public/browser/render_frame_host.h [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/public/common/BUILD.gn [delete] https://crrev.com/6749541aca4c8e7774a451c218fecc4d33b95034/content/public/common/form_field_data.cc [delete] https://crrev.com/6749541aca4c8e7774a451c218fecc4d33b95034/content/public/common/form_field_data.h [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/renderer/render_frame_impl.cc [modify] https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320/content/renderer/render_frame_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32d4b3a47daccad1a7ea2612753292d3552f6412 commit 32d4b3a47daccad1a7ea2612753292d3552f6412 Author: dpranke <dpranke@chromium.org> Date: Mon Nov 21 17:45:37 2016 Reland of Extracting placeholder information from Webkit to Blimp (patchset #1 id:1 of https://codereview.chromium.org/2513333002/ ) Reason for revert: The revert did not fix the problem, so I'm relanding this now. See also crbug.com/667147 . Original issue's description: > Revert of Extracting placeholder information from Webkit to Blimp (patchset #15 id:280001 of https://codereview.chromium.org/2370393002/ ) > > Reason for revert: > I'm speculatively reverting this to see if it causes the failure in blink_platform_unittests noted in https://crbug.com/667094 and as seen in > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20123 > > . It's not at all obvious to my why this would cause that failure, but it's not obvious to me what other changes would've, either, unless maybe it was pdr's change (which I will try if this doesn't fix it). > > Original issue's description: > > Extracting placeholder information from Webkit to Blimp > > > > For text input, the new Blimp IME requires few additional information > > associated with the text field such as label and placeholder attributes. > > For a mock UI, visit go/blimp-type-3 > > > > In this CL, the Blimp tab makes a call to RenderFrameHost to access > > the information about the currently focused text input field and > > supplies a callback to act upon obtaining the information. The > > RenderFrame gets the information, populates it into a FormFieldData > > struct and passes it to the browser which then invokes the supplied > > callback by the embedder. > > > > BUG= 651902 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > > > Committed: https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031 > > Cr-Commit-Position: refs/heads/master@{#433364} > > TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 651902 > > Committed: https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320 > Cr-Commit-Position: refs/heads/master@{#433460} TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 651902 Review-Url: https://codereview.chromium.org/2520013002 Cr-Commit-Position: refs/heads/master@{#433582} [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/blimp/engine/feature/engine_render_widget_feature.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/blimp/engine/feature/engine_render_widget_feature.h [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/blimp/engine/feature/engine_render_widget_feature_unittest.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/blimp/engine/session/blimp_engine_session.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/blimp/engine/session/tab.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/blimp/engine/session/tab.h [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/common/frame_messages.h [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/public/browser/render_frame_host.h [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/public/common/BUILD.gn [add] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/public/common/form_field_data.cc [add] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/public/common/form_field_data.h [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/renderer/render_frame_impl.cc [modify] https://crrev.com/32d4b3a47daccad1a7ea2612753292d3552f6412/content/renderer/render_frame_impl.h
Obsolete, WontFix.
Comment 1 by dtrainor@chromium.org
, Nov 15 2016Labels: -Pri-3 M-57 Pri-1