Sorry, I didn't realise this would impact cronet builds :/

Feel free to amend the assert if there's a build-time condition for a cronet build; this issue was just causing a lot of confusion for people building regular chromium and the assert seemed like the best way to highlight that this configuration is not functional in general.

Why does Cronet use non-component build? Can Cronet switch over to component build? I don't really understand the difference between the two.

Component builds package every component as a separate dynamic library, whereas cronet build packages them as static libraries and links them into single dynamic library, libcronet.so.

Thanks Misha for explaining!

torne@, can we change the following assert to skip non-component build?

from:

(!is_android || android_64bit_target_cpu || is_component_build || symbol_level < 2) 

to

((!is_android || android_64bit_target_cpu || symbol_level < 2) && is_component_build )

No, that would invert the meaning of the assertion. The point of the assertion is to verify that *at least one* of the things that makes the libraries "okay" is true: either building for non-android (other OSes don't have this problem for various reasons), or building for 64-bit (in which case >4gb binaries are fine), or building a component build (where libraries are much smaller), or building with a reduced symbol level.

If there's a build time variable for "cronet build" you can simply add this as a fifth case to the assertion, assuming unstripped cronet binaries are not at risk of exceeding 4gb any time soon. If there's not a variable for this, then there's not a really easy solution here: we might just have to add another variable specifically for this purpose (ignore_elf32_limitations=true or similar).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d32a26068321e5976494501c51a33636a42c13f

commit 6d32a26068321e5976494501c51a33636a42c13f
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Oct 06 16:58:03 2016

Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni

Add a ignore_elf32_limitations flag in
build/config/compiler/compiler.gni to turn off
assertion for Cronet builds.

This CL additionally adds is_clang to the
assertion per comment in 648948.

BUG= 651887 ,648948

Review-Url: https://codereview.chromium.org/2395603003
Cr-Commit-Position: refs/heads/master@{#423564}

[modify] https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f/build/config/compiler/compiler.gni
[modify] https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f/components/cronet/tools/cr_cronet.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d32a26068321e5976494501c51a33636a42c13f

commit 6d32a26068321e5976494501c51a33636a42c13f
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Oct 06 16:58:03 2016

Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni

Add a ignore_elf32_limitations flag in
build/config/compiler/compiler.gni to turn off
assertion for Cronet builds.

This CL additionally adds is_clang to the
assertion per comment in 648948.

BUG= 651887 ,648948

Review-Url: https://codereview.chromium.org/2395603003
Cr-Commit-Position: refs/heads/master@{#423564}

[modify] https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f/build/config/compiler/compiler.gni
[modify] https://crrev.com/6d32a26068321e5976494501c51a33636a42c13f/components/cronet/tools/cr_cronet.py

[Automated comment] removing mislabelled merge-merged-2840