New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651874 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[scroll anchoring] can't disable from about:flags

Project Member Reported by skobes@chromium.org, Sep 30 2016

Issue description

It looks like the canary trial forces scroll anchoring on even when it's disabled in about:flags.  That's bad.
 

Comment 1 by woxxom@gmail.com, Sep 30 2016

I've been using --force-fieldtrials in Chrome shortcut's command line to override other trials that were ignoring my chrome://flags.

Comment 2 by skobes@chromium.org, Sep 30 2016

Owner: skobes@chromium.org
Status: Started (was: Available)
The problem is that r418715 enabled the Blink runtime feature instead of the base::Feature.  The latter should control the former but runtime_features.cc only overrides it from false -> true and not the other direction.

Comment 3 by skobes@chromium.org, Sep 30 2016

A workaround is to use --disable-blink-features=ScrollAnchoring from the command line.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/560680291035d12baa675c8fd9681b1c04a4b4ac

commit 560680291035d12baa675c8fd9681b1c04a4b4ac
Author: skobes <skobes@chromium.org>
Date: Fri Sep 30 22:29:32 2016

Let features::kScrollAnchoring disable the Blink REF.

BUG= 651874 

Review-Url: https://codereview.chromium.org/2379053004
Cr-Commit-Position: refs/heads/master@{#422244}

[modify] https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac/content/child/runtime_features.cc

Comment 5 by skobes@chromium.org, Sep 30 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/953d83cf0e1ac70e6b5831c2bc09ac8a30c29cdf

commit 953d83cf0e1ac70e6b5831c2bc09ac8a30c29cdf
Author: qyearsley <qyearsley@chromium.org>
Date: Sun Oct 02 18:24:33 2016

Revert of Let features::kScrollAnchoring disable the Blink REF. (patchset #2 id:20001 of https://codereview.chromium.org/2379053004/ )

Reason for revert:
Speculative revert to see if it might fix http://crrev.com/652014

Original issue's description:
> Let features::kScrollAnchoring disable the Blink REF.
>
> BUG= 651874 
>
> Committed: https://crrev.com/560680291035d12baa675c8fd9681b1c04a4b4ac
> Cr-Commit-Position: refs/heads/master@{#422244}

TBR=avi@chromium.org,skobes@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 651874 

Review-Url: https://codereview.chromium.org/2390523002
Cr-Commit-Position: refs/heads/master@{#422350}

[modify] https://crrev.com/953d83cf0e1ac70e6b5831c2bc09ac8a30c29cdf/content/child/runtime_features.cc

Status: Assigned (was: Fixed)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b354d35be86d02fe23cedd5c06b6c78ffab9e469

commit b354d35be86d02fe23cedd5c06b6c78ffab9e469
Author: skobes <skobes@chromium.org>
Date: Mon Oct 03 20:25:40 2016

Reland "Let features::kScrollAnchoring disable the Blink REF" (r422244).

BUG= 651874 

Review-Url: https://codereview.chromium.org/2379053004
Cr-Commit-Position: refs/heads/master@{#422512}

[modify] https://crrev.com/b354d35be86d02fe23cedd5c06b6c78ffab9e469/content/child/runtime_features.cc

Status: Fixed (was: Assigned)

Sign in to add a comment