New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651870 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Flake in PageLoadMetricsBrowserTest.FirstMeaningfulPaintNotRecorded

Project Member Reported by jdufault@chromium.org, Sep 30 2016

Issue description

Here[1] is an example failure, the error message being

  Histogram "PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintStatus" does not exist.

This flaked once in the Linux ChromiumOS Tests[2] bot.

1: https://paste.googleplex.com/5258578390679552?raw
2: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/27044
 
Labels: -Pri-2 Pri-1
We seem to have a similar failure on PageLoadMetricsBrowserTest.NoStatePrefetchObserverCacheable with

Histogram "Prerender.none_NoStatePrefetchTTFCP.Reference.Cacheable" does not exist.

Raising to Pri-1 as this is creating noise on the bots.
Linux ChromiumOS Tests is passing reliably...
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29?numbuilds=200

...but this flake is still happening:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/27387/steps/browser_tests%20on%20Ubuntu-12.04/logs/stdio

Here, for instance, PageLoadMetricsBrowserTest.FirstMeaningfulPaintNotRecorded failed twice before succeeding on the second retry.

Comment 4 by pasko@chromium.org, Oct 18 2016

Cc: droger@chromium.org bmcquade@chromium.org mattcary@chromium.org
I created a separate bug for PageLoadMetricsBrowserTest.NoStatePrefetchObserverCacheable:  Issue 657022 .
This failure just re-occured: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54420

ksakamoto@, can you take a look or route this to someone else please?
ksakamoto, note that this most recent flake occurred with browser-side navigation enabled. To repro you'll want to include --enable-browser-side-navigation on the command line.
Status: Started (was: Assigned)
Sorry for the lack of activity.
Created a patch: https://codereview.chromium.org/2799423002/
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/115a1494e75fec1c214329b8e8f0be9b35194785

commit 115a1494e75fec1c214329b8e8f0be9b35194785
Author: ksakamoto <ksakamoto@chromium.org>
Date: Mon Apr 10 02:13:12 2017

Deflake PageLoadMetricsBrowserTest.FirstMeaningfulPaintNotRecorded

There are two causes of flakiness:

1. ui_test_utils::NavigateToURL() does not guarantee that the page had
   a paint after the navigation. FirstMeaningfulPaintStatus will not be
   logged if the page is not painted at all. This patch adds a FCP
   observer to prevent this.

2. The page may reach network-idle and report FirstMeaningfulPaint
   before the tester calls NavigateToUntrackedUrl(). To prevent this,
   this patch adds some slow fetch() requests in the test page.

BUG= 651870 

Review-Url: https://codereview.chromium.org/2799423002
Cr-Commit-Position: refs/heads/master@{#463165}

[modify] https://crrev.com/115a1494e75fec1c214329b8e8f0be9b35194785/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[add] https://crrev.com/115a1494e75fec1c214329b8e8f0be9b35194785/chrome/test/data/page_load_metrics/page_with_active_connections.html

Status: Fixed (was: Started)

Sign in to add a comment