New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651861 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Timing-Allow-Origin header should support list (comma separated) semantics

Project Member Reported by igrigo...@chromium.org, Sep 30 2016

Issue description

Version: 53.0.2785.116 (64-bit)
OS: Any

What steps will reproduce the problem?
(1) Test: https://github.com/w3c/resource-timing/issues/62#issuecomment-248440639

What is the expected output?
Chrome should allow comma separated values and/or multiple TAO headers. 

Updated spec: https://w3c.github.io/resource-timing/#timing-allow-origin
Related discussion: https://github.com/w3c/resource-timing/pull/68
 

Comment 1 by panicker@google.com, Apr 13 2017

Status: Available (was: Untriaged)
We landed updated tests along with the spec update, which should answer this: https://github.com/w3c/web-platform-tests/pull/5117
Also see  crbug.com/410875 .
Components: -Blink>PerformanceAPIs Blink>PerformanceAPIs>ResourceTiming
I would request that chromium specifically support comma separated values as some web serving systems are currently designed to only respond with a single TAO header

Comment 6 by y...@yoav.ws, Apr 14 2018

Cc: -y...@yoav.ws
Owner: y...@yoav.ws

Comment 7 by y...@yoav.ws, Apr 14 2018

Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65176dd732b75aa98260798276930ebcf9523b8

commit d65176dd732b75aa98260798276930ebcf9523b8
Author: Yoav Weiss <yoav@yoav.ws>
Date: Thu Apr 19 19:50:33 2018

[Resource Timing] Align TAO parsing to spec

TAO parsing had two issues:
* It was splitting the host values on whitespace rather than a comma. This
used to be the specified behavior, but changed in
https://github.com/w3c/resource-timing/pull/68
* When it was checking the different hosts in the host list, it was not checking
for "*" as a possible value.

This CL fixes those two issues and aligns the test expectations accordingly.

Bug:  651861 ,  833032 , 626703
Change-Id: I8a3b7e705ed7089719ad0f52607363392c7de934
Reviewed-on: https://chromium-review.googlesource.com/1013409
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#552127}
[modify] https://crrev.com/d65176dd732b75aa98260798276930ebcf9523b8/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_TAO_match_origin-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_TAO_match_wildcard-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_TAO_multi-expected.txt
[modify] https://crrev.com/d65176dd732b75aa98260798276930ebcf9523b8/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resources/TAOResponse.py
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/linux/external/wpt/resource-timing/resource_TAO_space-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/resource-timing/resource_TAO_space-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/resource-timing/resource_TAO_space-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/resource-timing/resource_TAO_space-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/mac/external/wpt/resource-timing/resource_TAO_space-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/win/external/wpt/resource-timing/resource_TAO_space-expected.txt
[delete] https://crrev.com/c976e6be607f2cde894a9933feffe6736e5b9192/third_party/WebKit/LayoutTests/platform/win7/external/wpt/resource-timing/resource_TAO_space-expected.txt
[modify] https://crrev.com/d65176dd732b75aa98260798276930ebcf9523b8/third_party/blink/renderer/core/timing/performance.cc

Comment 9 by y...@yoav.ws, Apr 19 2018

Status: Fixed (was: Started)
Cc: tdres...@chromium.org tommckee@chromium.org
 Issue 410875  has been merged into this issue.

Sign in to add a comment