New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651845 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert VLOG to DVLOG (2016 edition)

Project Member Reported by scottmg@chromium.org, Sep 30 2016

Issue description

It was noted long ago at https://groups.google.com/a/chromium.org/d/topic/chromium-dev/nAiKeh-zLws/discussion and https://bugs.chromium.org/p/chromium/issues/detail?id=101424 that VLOGs were a sizable chunk of the released code with limited utility.

At r148448ef, Windows, target_cpu=x86, is_debug=false, is_chrome_branded=true, is_official_build=true.

chrome.dll: 40,403,456
chrome_child.dll: 49,829,376
chrome_elf.dll: 415,232
chrome.exe: 940,533

Then, with VLOG/VLOG_IF compiled out https://codereview.chromium.org/2386613003 :

chrome.dll: 40,254,464
chrome_child.dll: 49,748,992
chrome_elf.dll: 414,208
chrome.exe: 938,496

For a difference of 232,255.

We should probably declare VLOG bankruptcy again and convert VLOG()s to DVLOG()s, again.
 
Cc: groby@chromium.org
(+groby per elsewhere discussion)

Comment 2 by yfa@google.com, Apr 30 2018

VLOG also consumes quite a lot CPU cycles. It would be nice to keep it out of release version.

Sign in to add a comment