Detected 12 new flakes for test/step "IsolatedAppTest.CrossProcessClientRedirect". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipJc29sYXRlZEFwcFRlc3QuQ3Jvc3NQcm9jZXNzQ2xpZW50UmVkaXJlY3QM. This message was posted automatically by the chromium-try-flakes app.

nasko@
Could you please handle this?

just saw it in https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/419389

Detected 11 new flakes for test/step "IsolatedAppTest.CrossProcessClientRedirect". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipJc29sYXRlZEFwcFRlc3QuQ3Jvc3NQcm9jZXNzQ2xpZW50UmVkaXJlY3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Test is disabled already removing sheriff label

fyi fix in https://codereview.chromium.org/2789783003/

Thanks Jam for putting together an initial fix! I've started working on a slightly different fix, which I'm hoping to send out for review today.

Before I send it out, though, I want to repro locally that I'm actually fixing the issue.

I'm having trouble repro'ing this issue on a build from trunk. I'm running:

ninja -C out/rel -j1000 browser_tests && ./out/rel/browser_tests --gtest_filter="IsolatedAppTest.DISABLED_CrossProcessClientRedirect" --single-process-tests --gtest_also_run_disabled_tests --enable_browser_side_navigation --gtest_repeat=100 --gtest_break_on_failure

but the test passed in 100 of 100 cases

my args.gn contains the following, in case it's important:
is_component_build = true
is_debug = false
enable_nacl = false
use_goma = true
dcheck_always_on = true

Should I be doing something differently to repro this issue?

--enable-browser-side-navigation :)

Ah, thanks! dash versus underscore :) ... or _-)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b17878ebc18e3f4df888b42ec74e5d3b4b0be94

commit 6b17878ebc18e3f4df888b42ec74e5d3b4b0be94
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Apr 06 01:47:16 2017

Update both end time and end reason when we don't have an end time.

In the PageLoadTracker destructor, if we encounter a load without
an end time, we use the current time as the end time.

However, this causes a DCHECK in GetPageLoadExtraInfo to fire shortly
after, since the end time and end reason are out of sync.

This change makes sure that both end time and end reason stay in sync
when this case is encountered.

This also re-enables a disabled test that was failing due to the
GetPageLoadExtraInfo DCHECK.

BUG=651844

Review-Url: https://codereview.chromium.org/2800873002
Cr-Commit-Position: refs/heads/master@{#462317}

[modify] https://crrev.com/6b17878ebc18e3f4df888b42ec74e5d3b4b0be94/chrome/browser/extensions/isolated_app_browsertest.cc
[modify] https://crrev.com/6b17878ebc18e3f4df888b42ec74e5d3b4b0be94/chrome/browser/page_load_metrics/page_load_tracker.cc

My patch should address the more recent issue. Not sure if it is related to the flakes originally reported in Oct 2016 however.