New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651843 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 651829



Sign in to add a comment

GLES2Interface is missing FlushMappedBufferRange

Project Member Reported by bsalomon@chromium.org, Sep 30 2016

Issue description

This function is part of ES3. It is needed to complete the bindings of Skia to ES3 in Chromium.
 
Blocking: 651829

Comment 2 by zmo@chromium.org, Sep 30 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f5a5a2f766dbaeb047e4a39e647be420f3530e9

commit 1f5a5a2f766dbaeb047e4a39e647be420f3530e9
Author: zmo <zmo@chromium.org>
Date: Wed Oct 05 01:20:00 2016

Implementing FlushMappedBufferRange in GPU command buffer.

Also adding some missing validation for MapBufferRange.

BUG= 429053 , 651843 
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2221173002
Cr-Commit-Position: refs/heads/master@{#423035}

[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/1f5a5a2f766dbaeb047e4a39e647be420f3530e9/gpu/command_buffer/service/gles2_cmd_decoder_unittest_buffers.cc

Comment 4 by zmo@chromium.org, Oct 5 2016

Cc: kbr@chromium.org vmi...@chromium.org piman@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment