Resource leak in arc support extension |
||||
Issue descriptionVersion: ToT OS: ChromeOS What steps will reproduce the problem? (1) Repeatedly enable/disable ARC on chrome://settings What is the expected output? - ARC support extension is property disposed. What do you see instead? - ARC support extension is kept alive, and on re-enabling a new extension is created. I.e., it infinitely just creates a new extensions.
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/824e668590c607e39ee4d8620de32016a920f2c2 commit 824e668590c607e39ee4d8620de32016a920f2c2 Author: hidehiko <hidehiko@chromium.org> Date: Fri Sep 30 20:03:45 2016 Fix resource leak on extension window closing. The ARC support extension should be unloaded on window closed. However, it is not, because the port connected to Chrome is kept. In such a case, background page is kept alive so that the extension will not be unloaded. This CL closes the port so that extension is unloaded. Also, the "close" related messaging across ArcAuthService, ArcSupportHost and extension's background.js is slightly cleaned up to remove the unnecessary/unused code. It could be as a preparation of fixing dependencies, too. BUG=b/31079732, 651838 TEST=Ran on device. Ran unittests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2380683008 Cr-Commit-Position: refs/heads/master@{#422196} [modify] https://crrev.com/824e668590c607e39ee4d8620de32016a920f2c2/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/824e668590c607e39ee4d8620de32016a920f2c2/chrome/browser/chromeos/arc/arc_support_host.cc [modify] https://crrev.com/824e668590c607e39ee4d8620de32016a920f2c2/chrome/browser/chromeos/arc/arc_support_host.h [modify] https://crrev.com/824e668590c607e39ee4d8620de32016a920f2c2/chrome/browser/resources/chromeos/arc_support/background.js
,
Oct 3 2016
,
Oct 7 2016
,
Oct 18 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hidehiko@chromium.org
, Sep 30 2016