New issue
Advanced search Search tips

Issue 651830 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 624365



Sign in to add a comment

[ARC] Convert ios/web/web_state

Project Member Reported by stkhapugin@chromium.org, Sep 30 2016

Issue description

Convert ios/web/web_state to compile with ARC
 
Issue 639325 has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a4ea729584ef7faa36d2f64db26b09bd14122ef

commit 2a4ea729584ef7faa36d2f64db26b09bd14122ef
Author: stkhapugin <stkhapugin@chromium.org>
Date: Tue Oct 04 13:54:40 2016

[ARC] Converts parts of ios/web/web_state to ARC.

Notable changes:
 * CRWWebViewProxyImpl now uses synthesized getter and ivar for
property contentView
 * CRWJSPOSTRequestLoader now does not create a retain cycle of
CRWWKScriptMessageRouter objects. The cycle seems to have been harmless,
but it definitely brings no value, and it's better to not have it.

BUG= 651830 

Review-Url: https://codereview.chromium.org/2380323002
Cr-Commit-Position: refs/heads/master@{#422776}

[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/BUILD.gn
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/public/web_state/crw_web_view_scroll_view_proxy.h
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/crw_web_view_proxy_impl.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/crw_web_view_scroll_view_proxy.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/error_translation_util.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/global_web_state_event_tracker.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/credential_util.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_injection_manager.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_injection_receiver.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_plugin_placeholder_manager.mm
[modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_post_request_loader.mm

Components: Internals Mobile>WebView>Glue
Labels: -Type-Bug Type-Task
This is now done. Right?
Status: Fixed (was: Assigned)
Right! thanks!

Sign in to add a comment