Convert ios/web/web_state to compile with ARC
Issue 639325 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a4ea729584ef7faa36d2f64db26b09bd14122ef commit 2a4ea729584ef7faa36d2f64db26b09bd14122ef Author: stkhapugin <stkhapugin@chromium.org> Date: Tue Oct 04 13:54:40 2016 [ARC] Converts parts of ios/web/web_state to ARC. Notable changes: * CRWWebViewProxyImpl now uses synthesized getter and ivar for property contentView * CRWJSPOSTRequestLoader now does not create a retain cycle of CRWWKScriptMessageRouter objects. The cycle seems to have been harmless, but it definitely brings no value, and it's better to not have it. BUG= 651830 Review-Url: https://codereview.chromium.org/2380323002 Cr-Commit-Position: refs/heads/master@{#422776} [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/BUILD.gn [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/public/web_state/crw_web_view_scroll_view_proxy.h [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/crw_web_view_proxy_impl.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/crw_web_view_scroll_view_proxy.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/error_translation_util.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/global_web_state_event_tracker.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/credential_util.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_injection_manager.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_injection_receiver.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_plugin_placeholder_manager.mm [modify] https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef/ios/web/web_state/js/crw_js_post_request_loader.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684 commit c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684 Author: stkhapugin <stkhapugin@chromium.org> Date: Mon Oct 17 09:53:06 2016 Notable changes:None BUG= 651830 Review-Url: https://codereview.chromium.org/2418143003 Cr-Commit-Position: refs/heads/master@{#425645} [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/BUILD.gn [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/public/web_state/ui/crw_generic_content_view.h [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/web_state/js/crw_js_window_id_manager.mm [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/web_state/js/page_script_util.mm [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/web_state/page_viewport_state.mm [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/web_state/ui/crw_generic_content_view.mm [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/web_state/ui/crw_touch_tracking_recognizer.h [modify] https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684/ios/web/web_state/ui/crw_touch_tracking_recognizer.mm
This is now done. Right?
Right! thanks!
Comment 1 by stkhapugin@chromium.org
, Oct 4 2016