What kind of side effects?

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7

commit a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7
Author: mlippautz <mlippautz@chromium.org>
Date: Fri Sep 30 13:57:27 2016

[heap] Remove unnecessary marking specializations

R=hpayer@chromium.org
BUG= chromium:651828 

Review-Url: https://codereview.chromium.org/2377203003
Cr-Commit-Position: refs/heads/master@{#39917}

[modify] https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7/src/heap/incremental-marking.cc
[modify] https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7/src/heap/mark-compact.cc
[modify] https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7/src/heap/objects-visiting.h
[modify] https://crrev.com/a5dfdb755df2ffb9ff3a932b4c55dc797adc63c7/src/objects.h

jochen: Basically anything beyond just marking the graph, e.g. code flushing, cleaning or code caches.

This is needed for young generation MC and parallel marking.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4d45ed4597d537cf9624cb6683dc4bd646d11242

commit 4d45ed4597d537cf9624cb6683dc4bd646d11242
Author: mlippautz <mlippautz@chromium.org>
Date: Wed Oct 05 08:26:42 2016

[heap] Simplify marking of JSFunction and SFI

BUG= chromium:651828 

Review-Url: https://codereview.chromium.org/2389183002
Cr-Commit-Position: refs/heads/master@{#39975}

[modify] https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242/src/heap/objects-visiting.h
[modify] https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242/src/objects.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5295d7a463cbcc78a4b694a7fb84af8e8e400303

commit 5295d7a463cbcc78a4b694a7fb84af8e8e400303
Author: epertoso <epertoso@chromium.org>
Date: Wed Oct 05 10:22:30 2016

Revert of [heap] Simplify marking of JSFunction and SFI (patchset #3 id:40001 of https://codereview.chromium.org/2389183002/ )

Reason for revert:
Broke GCStress.

Original issue's description:
> [heap] Simplify marking of JSFunction and SFI
>
> BUG= chromium:651828 
>
> Committed: https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242
> Cr-Commit-Position: refs/heads/master@{#39975}

TBR=hpayer@chromium.org,mlippautz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:651828 

Review-Url: https://codereview.chromium.org/2389963007
Cr-Commit-Position: refs/heads/master@{#39983}

[modify] https://crrev.com/5295d7a463cbcc78a4b694a7fb84af8e8e400303/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/5295d7a463cbcc78a4b694a7fb84af8e8e400303/src/heap/objects-visiting.h
[modify] https://crrev.com/5295d7a463cbcc78a4b694a7fb84af8e8e400303/src/objects.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1a9df4cec03d3575fb3fee898e546fe944a81b9f

commit 1a9df4cec03d3575fb3fee898e546fe944a81b9f
Author: mlippautz <mlippautz@chromium.org>
Date: Wed Oct 05 12:27:53 2016

Reland of [heap] Simplify marking of JSFunction and SFI (patchset #1 id:1 of https://codereview.chromium.org/2389963007/ )

Reason for revert:
Wrong culprit as this was already broken before.

Original issue's description:
> Revert of [heap] Simplify marking of JSFunction and SFI (patchset #3 id:40001 of https://codereview.chromium.org/2389183002/ )
>
> Reason for revert:
> Broke GCStress.
>
> Original issue's description:
> > [heap] Simplify marking of JSFunction and SFI
> >
> > BUG= chromium:651828 
> >
> > Committed: https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242
> > Cr-Commit-Position: refs/heads/master@{#39975}
>
> TBR=hpayer@chromium.org,mlippautz@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= chromium:651828 
>
> Committed: https://crrev.com/5295d7a463cbcc78a4b694a7fb84af8e8e400303
> Cr-Commit-Position: refs/heads/master@{#39983}

TBR=hpayer@chromium.org,epertoso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:651828 

Review-Url: https://codereview.chromium.org/2390373004
Cr-Commit-Position: refs/heads/master@{#39990}

[modify] https://crrev.com/1a9df4cec03d3575fb3fee898e546fe944a81b9f/src/heap/objects-visiting-inl.h
[modify] https://crrev.com/1a9df4cec03d3575fb3fee898e546fe944a81b9f/src/heap/objects-visiting.h
[modify] https://crrev.com/1a9df4cec03d3575fb3fee898e546fe944a81b9f/src/objects.h

We have less side effects by now and a story of how to deal with them in concurrent settings. See the concurrent marker.