Issue metadata
Sign in to add a comment
|
20.5% regression in thread_times.key_idle_power_cases at 421067:421097 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 30 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9000093987008870384
,
Sep 30 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Idle cleanup for worker context Author : ericrk Commit description: Currently, Skia flushes unused items out of its caches after ~1 second of non-use (50 flushes). This works fine while Skia is in-use, but when a worker context goes idle we stop calling into Skia altogether. This means that Skia will never flush out unused cache items from the last piece of work it did. This can lead to some rather large temporaries being kept around (~20mb). This change adds an idle cleanup process which flushes Skia's caches and cleans up worker context resources after a worker context is idle for 1 second. BUG= 624630 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:linux_precise_blink_dbg Committed: https://crrev.com/051ae83bf29b52cefd82235ebfb90f203912afbb Review-Url: https://codereview.chromium.org/2353033003 Cr-Original-Commit-Position: refs/heads/master@{#420496} Cr-Commit-Position: refs/heads/master@{#421092} Commit : 6714c23b526197220d8b9abdbd38b6d9c206d912 Date : Tue Sep 27 03:37:20 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@421066 4.1237 0.0455333 5 good chromium@421082 4.16398 0.0265539 5 good chromium@421090 4.1733 0.0745681 5 good chromium@421091 4.14444 0.0498725 5 good chromium@421092 4.92205 0.0679366 5 bad <-- chromium@421094 4.9719 0.0284724 5 bad chromium@421097 5.02135 0.0573073 5 bad Bisect job ran on: android_nexus5X_perf_bisect Bug ID: 651803 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases Test Metric: tasks_per_second_total_all/animated-gif.html Relative Change: 21.77% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/711 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000093987008870384 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5550531940974592 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by pmeenan@chromium.org
, Sep 30 2016