New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651798 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Ship Path2D.prototype.addPath

Project Member Reported by foolip@chromium.org, Sep 30 2016

Issue description

Firefox and Safari have Path2D.prototype.addPath, in Chrome it is [RuntimeEnabled=ExperimentalCanvasFeatures].

This showed up in https://docs.google.com/spreadsheets/d/1Fqv1JyadCDGMJ91GdIYPQicI97ELIHabwUfxFQv-jLU/edit#gid=0
 

Comment 1 by junov@chromium.org, Sep 30 2016

Owner: xlai@chromium.org
Status: Assigned (was: Untriaged)
Hmmm... looks like it got left behind.

@xlai: could you take this through the launch process? Make sure it is rigorously tested and compatible first.  The current implementation uses SVGMatrix, and the spec calls for DOMMatrixInit, so you may want to look into that, and see what other implementations are doing.
Labels: -Type-Bug Type-Feature
Path2D docs still specifically indicate support for this feature in Chrome.  https://developer.mozilla.org/en-US/docs/Web/API/Path2D
Is there anything preventing this feature from shipping?

Comment 5 by junov@chromium.org, Apr 5 2017

Yeah... This has a dependency on DOMMatrix, and the shipping of DOM geometry interfaces has run into some hurdles.

The thread is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/cAiTOdSGyes

Comment 6 by junov@chromium.org, Jul 17 2017

Owner: fs...@chromium.org

Comment 7 by junov@chromium.org, Jul 17 2017

Now that DOMMatrix is shipping, this is unblocked.
Is this feature waiting on anything else?

Comment 9 by fs...@chromium.org, Sep 21 2017

Status: Started (was: Assigned)
working on DOMMatrix change. Stay tunned.

Comment 10 by f...@opera.com, Feb 19 2018

 Issue 813350  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26ea97726ef213927ed86a06836dd16a8b33275f

commit 26ea97726ef213927ed86a06836dd16a8b33275f
Author: Fernando Serboncini <fserb@chromium.org>
Date: Wed May 16 15:45:49 2018

Clean up remaining Canvas SVGMatrix to DOMMatrix

- Canvas2D.addPath
- CanvasPattern
- PaintRenderingContext
- removes currentTransform

Bug:  651798 
Change-Id: If4c94253d6b060964c1575eb7f189979b42486e5
Reviewed-on: https://chromium-review.googlesource.com/677643
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559120}
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/external/wpt/css/geometry/DOMMatrix2DInit-validate-fixup-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.https-expected.txt
[delete] https://crrev.com/ebeb0698d0c29975f93c40b0b078c6764b1ad22a/third_party/WebKit/LayoutTests/fast/canvas-api/currentTransform-null-expected.txt
[delete] https://crrev.com/ebeb0698d0c29975f93c40b0b078c6764b1ad22a/third_party/WebKit/LayoutTests/fast/canvas-api/currentTransform-null.html
[delete] https://crrev.com/ebeb0698d0c29975f93c40b0b078c6764b1ad22a/third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/fast/canvas/canvas-path-addpath.html
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/core/geometry/dom_matrix.cc
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/core/geometry/dom_matrix.h
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/core/geometry/dom_matrix_read_only.cc
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/core/geometry/dom_matrix_read_only.h
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/canvas_pattern.cc
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/canvas_pattern.h
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/canvas_pattern.idl
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.idl
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/path_2d.h
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/canvas/canvas2d/path_2d.idl
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/modules/csspaint/paint_rendering_context_2d.idl
[modify] https://crrev.com/26ea97726ef213927ed86a06836dd16a8b33275f/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 12 by fs...@chromium.org, May 16 2018

Status: Fixed (was: Started)
DONERINO

Sign in to add a comment