New issue
Advanced search Search tips

Issue 651792 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

CSSMediaRule and CSSSupportsRule should inherit from CSSConditionRule

Project Member Reported by foolip@chromium.org, Sep 30 2016

Issue description

https://drafts.csswg.org/css-conditional/#the-cssmediarule-interface
https://drafts.csswg.org/css-conditional/#the-csssupportsrule-interface

Edge and Firefox have the CSSConditionRule interface, Safari does not. Implementing this would bring us closer to interop.
 
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Thanks Philip. Do you mind whipping up a quick test for this?

Comment 2 by xing...@intel.com, Oct 12 2016

Hi, I am interested with this issue and will trying to upload a CL for this.
Owner: xing...@intel.com
Status: Assigned (was: Available)

Comment 4 by foolip@chromium.org, Oct 17 2016

Labels: -Type-Bug OWP-Standards-OfficialSpec OWP-Type-ChangeAPI Type-Launch-OWP
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae

commit 4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae
Author: xing.xu <xing.xu@intel.com>
Date: Tue Oct 18 14:14:19 2016

CSSMediaRule and CSSSupportsRule inherit from CSSConditionRule

From the spec, the conditionText attribute of CSSMediaRule (inherited from CSSConditionRule parent rule), on getting, must return the value of media.mediaText on the rule. Setting the conditionText attribute must set the media.mediaText attribute on the rule. So conditionText of CSSConditionRule should be mutable instead of readonly, this is a TODO.

Spec:
https://drafts.csswg.org/css-conditional/#the-cssmediarule-interface
https://drafts.csswg.org/css-conditional/#the-csssupportsrule-interface
https://drafts.csswg.org/css-conditional/#the-cssconditionrule-interface

BUG= 651792 

Review-Url: https://codereview.chromium.org/2416893002
Cr-Commit-Position: refs/heads/master@{#425950}

[add] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/LayoutTests/css3/condition-cssom.html
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/LayoutTests/css3/supports-cssom-expected.txt
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/LayoutTests/css3/supports-cssom.html
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/BUILD.gn
[add] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSConditionRule.cpp
[add] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSConditionRule.h
[add] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSConditionRule.idl
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSMediaRule.cpp
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSMediaRule.h
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSMediaRule.idl
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSSupportsRule.cpp
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSSupportsRule.h
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/CSSSupportsRule.idl
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/StyleRule.cpp
[modify] https://crrev.com/4aaf16a74e94cae754d8e65ddcf0bd1dafefc0ae/third_party/WebKit/Source/core/css/StyleRule.h

Comment 6 by xing...@intel.com, Oct 20 2016

Status: Fixed (was: Assigned)

Sign in to add a comment