New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651773 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
ricea@chromium.org
█ tyoshino@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651572



Sign in to add a comment

Many failing web-platform-tests for Web Sockets that pass in Firefox and Edge

Project Member Reported by foolip@chromium.org, Sep 30 2016 
http://w3c-test.org/websockets/Close-1000-reason.htm
http://w3c-test.org/websockets/Close-1000.htm
http://w3c-test.org/websockets/Close-reason-unpaired-surrogates.htm
http://w3c-test.org/websockets/Create-Secure-url-with-space.htm
http://w3c-test.org/websockets/Create-Secure-valid-url-array-protocols.htm
http://w3c-test.org/websockets/Create-Secure-valid-url-binaryType-blob.htm
http://w3c-test.org/websockets/Create-Secure-valid-url-protocol-setCorrectly.htm
http://w3c-test.org/websockets/Create-Secure-valid-url-protocol-string.htm
http://w3c-test.org/websockets/Create-Secure-valid-url.htm
http://w3c-test.org/websockets/Create-valid-url-array-protocols.htm
http://w3c-test.org/websockets/Create-valid-url-protocol.htm
http://w3c-test.org/websockets/Create-valid-url.htm
http://w3c-test.org/websockets/Secure-Close-1000-reason.htm
http://w3c-test.org/websockets/Secure-Close-1000-verify-code.htm
http://w3c-test.org/websockets/Secure-Close-1000.htm
http://w3c-test.org/websockets/Secure-Close-1005-verify-code.htm
http://w3c-test.org/websockets/Secure-Close-3000-reason.htm
http://w3c-test.org/websockets/Secure-Close-3000-verify-code.htm
http://w3c-test.org/websockets/Secure-Close-4999-reason.htm
http://w3c-test.org/websockets/Secure-Close-Reason-Unpaired-surrogates.htm
http://w3c-test.org/websockets/Secure-Close-readyState-Closed.htm
http://w3c-test.org/websockets/Secure-Close-server-initiated-close.htm
http://w3c-test.org/websockets/Secure-Send-65K-data.htm
http://w3c-test.org/websockets/Secure-Send-binary-65K-arraybuffer.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybuffer.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-float32.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-float64.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-int32.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-uint16-offset-length.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-uint32-offset.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-uint8-offset-length.htm
http://w3c-test.org/websockets/Secure-Send-binary-arraybufferview-uint8-offset.htm
http://w3c-test.org/websockets/Secure-Send-binary-blob.htm
http://w3c-test.org/websockets/Secure-Send-data.htm
http://w3c-test.org/websockets/Secure-Send-null.htm
http://w3c-test.org/websockets/Secure-Send-paired-surrogates.htm
http://w3c-test.org/websockets/Secure-Send-unpaired-surrogates.htm
http://w3c-test.org/websockets/Send-0byte-data.htm
http://w3c-test.org/websockets/Send-65K-data.htm
http://w3c-test.org/websockets/Send-Unpaired-Surrogates.htm
http://w3c-test.org/websockets/Send-binary-65K-arraybuffer.htm
http://w3c-test.org/websockets/Send-binary-arraybuffer.htm
http://w3c-test.org/websockets/Send-binary-arraybufferview-int16-offset.htm
http://w3c-test.org/websockets/Send-binary-arraybufferview-int8.htm
http://w3c-test.org/websockets/Send-binary-blob.htm
http://w3c-test.org/websockets/Send-data.htm
http://w3c-test.org/websockets/Send-null.htm
http://w3c-test.org/websockets/Send-paired-surrogates.htm
http://w3c-test.org/websockets/Send-unicode-data.htm
http://w3c-test.org/websockets/closing-handshake/002.html
http://w3c-test.org/websockets/closing-handshake/003.html
http://w3c-test.org/websockets/closing-handshake/004.html
http://w3c-test.org/websockets/constructor/002.html
http://w3c-test.org/websockets/constructor/002.html?wss
http://w3c-test.org/websockets/constructor/011.html
http://w3c-test.org/websockets/interfaces/CloseEvent/clean-close.html
http://w3c-test.org/websockets/opening-handshake/002.html
http://w3c-test.org/websockets/opening-handshake/003.html

These failures need analysis, but may point to low-hanging fruit for improving interop. Judgement is required, the failures may be entangled with spec issues.

See  issue 651572  for the source of this data, which includes failing subtests.

Note: Results may have changed in the interim.

Comment 1 by ricea@chromium.org, Oct 3 2016 

I took a very brief look. Many tests are failing with

assert_equals: wasClean should be true expected true but got false

This is happening on a normal browser-initiated close, so we shouldn't be failing. Either we have some bug that is triggered by the web-platform-tests but not by our layout tests, or there's something odd going on with the test harness.

There are some tests with different issues that might be easier to fix, eg. websockets/constructor/002.html.

Comment 2 by rbyers@chromium.org, Dec 15 2016

Cc: tyoshino@chromium.org ricea@chromium.org
ricea@, since you've taken a look and agree there are some things worth looking into here, should we perhaps mark this as 'Available' with an appropriate priority to get it off the "untriaged" Hotlist-Interop list?  Blink>Network has a long tail of untriaged bugs :-(

Comment 3 by yhirano@chromium.org, Dec 16 2016

Status: Available (was: Untriaged)

Comment 4 by ricea@chromium.org, Dec 11 2017 

I fixed up some w-p-t WebSocket tests recently: https://github.com/w3c/web-platform-tests/pull/7345. Unfortunately, there are many broken tests and we cannot justify resources to fix them. The good news is, in many cases the browsers were interoperable and only the tests were wrong.

This issue is very nearly "WontFix" but if some kind person fixes the tests then we can take another look.

Comment 5 by foolip@chromium.org, Dec 12 2017

Status: WontFix (was: Available)
WontFixing then, I think the right approach here would be for those incorrect tests to show up in a triage in upstream web-platform-tests, using up-to-date results from all browsers on wpt.fyi.
►

Sign in to add a comment