New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Launch-OWP
Launch-Accessibility: NA
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: NA
Launch-M-Approved: 59-Dev
Launch-M-Target: 59-Dev
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA

Blocking:
issue 673664
issue 651572
issue 697598



Sign in to add a comment
link

Issue 651767: DeviceOrientationEvent and DeviceMotionEvent constructors

Reported by foolip@chromium.org, Sep 30 2016 Project Member

Issue description

http://w3c-test.org/orientation-event/idlharness.html

These failures need analysis, but at a glance, DeviceOrientationEvent and DeviceMotionEvent constructors is probably the bulk of the problem.

See  issue 651572  for the source of this data, which includes failing subtests.

Note: Results may have changed in the interim.
 

Comment 1 by foolip@chromium.org, Sep 30 2016

Components: IO>DeviceOrientation
I don't know if there's an appropriate Blink component for this, adding IO>DeviceOrientation.

Comment 2 by schenney@chromium.org, Sep 30 2016

Components: -Blink Blink>Bindings

Comment 3 by foolip@chromium.org, Sep 30 2016

Cc: timvolod...@chromium.org

Comment 4 by dk...@chromium.org, Oct 24 2016

Cc: haraken@chromium.org
+haraken since this might be a bindings issue - can you help triage here Kentaro?

Comment 5 by foolip@chromium.org, Oct 24 2016

The bindings support for this should be sufficient, it's just a matter of actually implementing the constructors. https://codereview.chromium.org/2347103003 is fairly similar case to show the amount of code involved.

Comment 6 by foolip@chromium.org, Dec 13 2016

Blocking: 673664

Comment 7 by dk...@chromium.org, Feb 6 2017

Cc: -timvolod...@chromium.org
Owner: timvolod...@chromium.org
@Tim - are you the right person to get this triaged? Can you get it to the right place? :)

Comment 8 by dougt@chromium.org, Feb 27 2017

Owner: reillyg@chromium.org
Status: Assigned (was: Untriaged)
reillyg, can you take a look?

Comment 9 by reillyg@chromium.org, Feb 27 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Started (was: Assigned)
I have patches that add these two events. Just need to go through the Intent to Implement and Ship process before I can land them.

Comment 10 by reillyg@chromium.org, Feb 28 2017

Labels: -Type-Bug OWP-Type-NewAPI Type-Launch-OWP
Marking this as an OWP launch bug so create a Chrome Feature entry.

Comment 11 by reillyg@chromium.org, Feb 28 2017

Labels: Launch-Accessibility-NA Launch-Privacy-NA Launch-UI-NA
Marking accessibility, privacy and UI as N/A as this is a trivial addition to the API to make Chrome spec compliant and consistent with other browsers. Need to check on whether I can do the same for security and legal. Tests can be imported from web-platform-tests.

Comment 12 by reillyg@chromium.org, Mar 3 2017

Blocking: 697598

Comment 13 by reillyg@chromium.org, Mar 3 2017

Labels: Launch-M-Target-58-Dev

Comment 14 by reillyg@chromium.org, Mar 3 2017

Labels: Launch-Status-Review-Requested

Comment 15 by bugdroid1@chromium.org, Mar 6 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f08a50143c87ad0d41c03a0370884eccb788b39

commit 3f08a50143c87ad0d41c03a0370884eccb788b39
Author: reillyg <reillyg@chromium.org>
Date: Mon Mar 06 18:26:49 2017

Implement DeviceMotionEvent constructor.

This patch adds the DeviceMotionEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#devicemotion

DeviceAccelerationInit, DeviceMotionEventInit and DeviceRotationRateInit
IDL dictionaries are added as dependencies.

BUG= 651767 

Review-Url: https://codereview.chromium.org/2720943002
Cr-Commit-Position: refs/heads/master@{#454893}

[add] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceAccelerationInit.idl
[modify] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
[modify] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h
[modify] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp
[modify] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.h
[modify] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl
[add] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEventInit.idl
[add] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/device_orientation/DeviceRotationRateInit.idl
[modify] https://crrev.com/3f08a50143c87ad0d41c03a0370884eccb788b39/third_party/WebKit/Source/modules/modules_idl_files.gni

Comment 16 by reillyg@chromium.org, Mar 6 2017

Labels: -Launch-M-Target-58-Dev Launch-M-Target-59-Dev
Missed the M-58 branch. This is not time critical so targeting launch in M-59 as the patches are landing now.

Comment 17 by reillyg@chromium.org, Mar 7 2017

Labels: -Launch-Status-Review-Requested Launch-Legal-NA Launch-M-Approved-59-Dev Launch-Security-NA Launch-Test-NA
Updating launch flags to indicate that this has gotten the necessary number of LGTMs on the Intent to Implement and Ship thread:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/7hkppntYQxc/ADSGnvWGDwAJ

Comment 18 by bugdroid1@chromium.org, Mar 7 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e559b21a078a2f02e02613f5cbf805903bcd8a17

commit e559b21a078a2f02e02613f5cbf805903bcd8a17
Author: reillyg <reillyg@chromium.org>
Date: Tue Mar 07 21:56:29 2017

Implement DeviceOrientationEvent constructor.

This patch adds the DeviceOrientationEvent constructor as defined in the
spec:

https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientation

The DeviceOrientationEventInit IDL dictionary is added as a dependency.

BUG= 651767 

Review-Url: https://codereview.chromium.org/2720003003
Cr-Commit-Position: refs/heads/master@{#455234}

[modify] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.cpp
[modify] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h
[modify] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp
[modify] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h
[modify] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
[add] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl
[modify] https://crrev.com/e559b21a078a2f02e02613f5cbf805903bcd8a17/third_party/WebKit/Source/modules/modules_idl_files.gni

Comment 19 by bugdroid1@chromium.org, Mar 7 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fec2991e99c468610b90b26f1aa017cfe2834af8

commit fec2991e99c468610b90b26f1aa017cfe2834af8
Author: reillyg <reillyg@chromium.org>
Date: Tue Mar 07 23:48:53 2017

W3CImportExpectations: Un-skip wpt/orientation-event.

Now that the DeviceMotionEvent and DeviceOrientationEvent constructors
are implemented the majority of these tests should pass.

BUG= 651767 

Review-Url: https://codereview.chromium.org/2737653003
Cr-Commit-Position: refs/heads/master@{#455294}

[modify] https://crrev.com/fec2991e99c468610b90b26f1aa017cfe2834af8/third_party/WebKit/LayoutTests/W3CImportExpectations

Comment 20 by reillyg@chromium.org, Mar 8 2017

Updated the chromestatus.com entry to reflect that this is now enabled by default in M-59. Marking this bug as fixed as there is no further action necessary in order to ship.

https://www.chromestatus.com/feature/4659236399218688

Comment 21 by reillyg@chromium.org, Mar 8 2017

Status: Fixed (was: Started)

Comment 22 by reillyg@chromium.org, Apr 19 2017

Components: -IO>DeviceOrientation Blink>Sensor

Sign in to add a comment