14 failing web-platform-tests for Fetch that pass in Firefox and Edge |
||||||||||||||
Issue descriptionhttps://wpt.fyi/results/fetch/api/basic/integrity-worker.html https://wpt.fyi/results/fetch/api/basic/request-headers-worker.html https://wpt.fyi/results/fetch/api/basic/request-headers.html https://wpt.fyi/results/fetch/api/basic/scheme-about-worker.html https://wpt.fyi/results/fetch/api/basic/scheme-about.html https://wpt.fyi/results/fetch/api/headers/headers-idl.html https://wpt.fyi/results/fetch/api/request/request-cache.html https://wpt.fyi/results/fetch/api/request/request-idl.html https://wpt.fyi/results/fetch/api/request/request-structure.html https://wpt.fyi/results/fetch/api/response/response-idl.html https://wpt.fyi/results/fetch/nosniff/image.html https://wpt.fyi/results/fetch/nosniff/importscripts.html https://wpt.fyi/results/fetch/nosniff/parsing-nosniff.html https://wpt.fyi/results/fetch/nosniff/worker.html Edit: most of these tests have been renamed, so links are broken. These failures need analysis, but may point to low-hanging fruit for improving interop. Judgement is required, the failures may be entangled with spec issues. See issue 651572 for the source of this data, which includes failing subtests. Note: Results may have changed in the interim.
,
Jan 3 2017
Looks like the blocking issue (627309) has been fixed. Anything else blocking work on this now?
,
Jan 4 2017
There are still some failures in these tests, though it's hard to tell if they're the same as when this issue was filed. Let's leave this as untriaged for someone working on Fetch to import these tests into Blink, or judge it as actually fixed already. We will try to generate this data again, so closing this doesn't risk losing track of the problem long term.
,
Jan 4 2017
I did a quick triage of what remains, in Canary (Version 57.0.2971.0 (Official Build) canary (64-bit)): - http://w3c-test.org/fetch/api/basic/integrity-worker.html: causes a crash, and in fact causes a crash of all open tabs if I open all the tests in a single Canary window - http://w3c-test.org/fetch/api/basic/scheme-about.html and -worker.html version: we disallow fetching about:blank, when we shouldn't - http://w3c-test.org/fetch/api/headers/headers-idl.html: https://bugs.chromium.org/p/chromium/issues/detail?id=643712 - http://w3c-test.org/fetch/api/request/request-cache.html: this test seems to have been removed - http://w3c-test.org/fetch/api/request/request-idl.html and http://w3c-test.org/fetch/api/request/request-structure.html : - https://bugs.chromium.org/p/chromium/issues/detail?id=643712 - Request is mising attributes type, destination, and cache, as well as the formData method - http://w3c-test.org/fetch/api/response/response-idl.html - https://bugs.chromium.org/p/chromium/issues/detail?id=643712 - Response is missing the formData method - http://w3c-test.org/fetch/nosniff/importscripts.html, http://w3c-test.org/fetch/nosniff/parsing-nosniff.html, http://w3c-test.org/fetch/nosniff/worker.html: presumably our nosniff implementation is not per spec
,
Jan 5 2017
Thanks! - http://w3c-test.org/fetch/nosniff/importscripts.html, http://w3c-test.org/fetch/nosniff/parsing-nosniff.html, http://w3c-test.org/fetch/nosniff/worker.html: presumably our nosniff implementation is not per spec I've wondered where sniffing is specified. Can you tell me?
,
Jan 5 2017
,
Jan 5 2017
http://w3c-test.org/fetch/nosniff/parsing-nosniff.html MimeSniffingResourceHandler::ShouldSniffContent() is using HttpResponseHeaders::GetNormalizedHeader() which returns values of headers with the specified name concatenated with ", ". The test is expecting that the last occurrence of the "X-Content-Type-Options" header to be parsed and it prevents sniffing. When sniffing is prevented, the Content-Type header value is used which is "x/x" to fail the script element. https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-nosniff? is saying that the first header should be used and these tests are for testing that (see https://github.com/w3c/web-platform-tests/pull/1715 ) though this algorithm is not used to control sniffing yet in the Fetch Standard.
,
Jan 5 2017
http://w3c-test.org/fetch/nosniff/importscripts.html Expecting a network error on importScripts() on a resource with non JavaScript MIME type as specified in the Main Fetch's step 16. Chrome doesn't throw a network error. See - https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-imported-script - https://html.spec.whatwg.org/multipage/workers.html#dom-workerglobalscope-importscripts
,
Jan 5 2017
Sniffing is defined by https://mimesniff.spec.whatwg.org/
,
Jan 20 2017
Setting blocked on issue 643712 for fetch/api/headers/headers-idl.html so this bug will track however that turns out.
,
Mar 27 2017
Is there a plan to import Fetch tests to external/wpt? The workers team is starting to fix service worker WPT tests, and we're seeing some failures are due to the Fetch API. For example, the Request constructor: https://codereview.chromium.org/2772013002/ We're going to add more Request tests to http/tests/fetch as we go, but it'd possibly de-duplicate effort if there are WPT tests already covering this or if we can commit directly to WPT tests.
,
Mar 29 2017
> Is there a plan to import Fetch tests to external/wpt? This just happened in bug 705490: https://codereview.chromium.org/2778753002
,
Apr 5 2017
From the above discussion it sounds like this is "triaged" - legitimate potential work on the network API team's backlog, just not given any particular priority yet. Right?
,
Apr 5 2017
,
May 9 2017
,
May 9 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 10 2018
,
Oct 12
A few of the pass also in Safari and are thus Chrome-only failures: https://wpt.fyi/results/fetch/api/policies/csp-blocked-worker.html?products=chrome%5Bexperimental%5D,edge%5Bstable%5D,firefox%5Bstable%5D,safari%5Bstable%5D&sha=434ca47448 https://wpt.fyi/results/fetch/api/redirect/redirect-location.any.html?products=chrome%5Bexperimental%5D,edge%5Bstable%5D,firefox%5Bstable%5D,safari%5Bstable%5D&sha=434ca47448 (from https://gist.github.com/foolip/bb5dc2b02cc87ac4412dcd348868edd1)
,
Oct 12
,
Oct 12
,
Oct 17
,
Oct 18
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by yhirano@chromium.org
, Oct 11 2016