New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Closed
Owner: ----
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 627682

Blocking:
issue 651572



Sign in to add a comment
link

Issue 651757: 2 failing web-platform-tests for XPath that pass in Firefox and Edge

Reported by foolip@chromium.org, Sep 30 2016 Project Member

Issue description

https://wpt.fyi/results/domxpath/001.html
https://wpt.fyi/results/domxpath/002.html

These failures need analysis, but may point to low-hanging fruit for improving interop. Judgement is required, the failures may be entangled with spec issues.

See  issue 651572  for the source of this data, which includes failing subtests.

Note: Results may have changed in the interim.
 

Comment 1 by tkent@chromium.org, Oct 7 2016

Components: -Blink>DOM Blink>XML
Status: Available (was: Untriaged)

Comment 2 by dominicc@chromium.org, Oct 14 2016

Blockedon: 627682
FWIW Firefox and Chrome both fail (but disagree) on "Select both HTML and SVG elements based on mixed case attribute" (Chrome finds 0 elements; Firefox finds 3.)

I think some of our failures result from Issue 627682 because these mention case a bit.

Did some digging into one of these cases:

http://w3c-test.org/domxpath/002.html Select HTML element with non-ascii attribute 3/assert_array_equals: lengths differ, expected 1 got 0

The test is trying to select <div id="log" nonÄsciiAttribute> with //*[@nonÄsciiAttribute] but note that element's attribute name has been adjusted by the HTML parser to nonÄsciiattribute.

Here's where XPath tries to look up the attribute:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/xml/XPathStep.cpp?sq=package:chromium&rcl=1476415104&l=389

getAttributeNS boils down to doing AttributeCollection::find--exact equality--when it should use equalsIgnoringASCIICase. (findSlowCase is almost right but it does equalsIgnoringCase.)

Comment 3 by dominicc@chromium.org, Oct 14 2016

Owner: dominicc@chromium.org
Tentatively me but feel free to poach.

Comment 4 by bugdroid1@chromium.org, Nov 21 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63d26d050ffc4707fabaef0cac4206f8118cea45

commit 63d26d050ffc4707fabaef0cac4206f8118cea45
Author: tkent <tkent@chromium.org>
Date: Mon Nov 21 09:51:56 2016

WPT: Request to import domparsing, domxpath, and innerText.

BUG= 651752 ,  651757 , 573309
NOTRY=true

Review-Url: https://codereview.chromium.org/2516983003
Cr-Commit-Position: refs/heads/master@{#433500}

[modify] https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45/third_party/WebKit/LayoutTests/W3CImportExpectations

Comment 5 by dominicc@chromium.org, Aug 22 2017

Cc: dominicc@chromium.org
Owner: ----
Bulk disowning per sshruthi's email about bug triage best practices.

Comment 6 by sheriffbot@chromium.org, Aug 22

Project Member
Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by foolip@chromium.org, Aug 30

Status: Available (was: Untriaged)

Comment 8 by foolip@chromium.org, Oct 12

Description: Show this description

Comment 9 by foolip@chromium.org, Oct 12

Things have changed since this bug was filed. The only Chrome failure in https://wpt.fyi/results/domxpath/001.html also fails in Edge.

https://wpt.fyi/results/domxpath/002.html?sha=c09b8005b2 does still show a test that fails in Chrome bug passes in Firefox and Edge. It also fails in Safari though.

I think issue 627682 is enough to track this.

Comment 10 by foolip@chromium.org, Oct 12

Status: Closed (was: Available)

Sign in to add a comment