2 failing web-platform-tests for XPath that pass in Firefox and Edge |
||||||||
Issue descriptionhttps://wpt.fyi/results/domxpath/001.html https://wpt.fyi/results/domxpath/002.html These failures need analysis, but may point to low-hanging fruit for improving interop. Judgement is required, the failures may be entangled with spec issues. See issue 651572 for the source of this data, which includes failing subtests. Note: Results may have changed in the interim.
,
Oct 14 2016
FWIW Firefox and Chrome both fail (but disagree) on "Select both HTML and SVG elements based on mixed case attribute" (Chrome finds 0 elements; Firefox finds 3.) I think some of our failures result from Issue 627682 because these mention case a bit. Did some digging into one of these cases: http://w3c-test.org/domxpath/002.html Select HTML element with non-ascii attribute 3/assert_array_equals: lengths differ, expected 1 got 0 The test is trying to select <div id="log" nonÄsciiAttribute> with //*[@nonÄsciiAttribute] but note that element's attribute name has been adjusted by the HTML parser to nonÄsciiattribute. Here's where XPath tries to look up the attribute: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/xml/XPathStep.cpp?sq=package:chromium&rcl=1476415104&l=389 getAttributeNS boils down to doing AttributeCollection::find--exact equality--when it should use equalsIgnoringASCIICase. (findSlowCase is almost right but it does equalsIgnoringCase.)
,
Oct 14 2016
Tentatively me but feel free to poach.
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63d26d050ffc4707fabaef0cac4206f8118cea45 commit 63d26d050ffc4707fabaef0cac4206f8118cea45 Author: tkent <tkent@chromium.org> Date: Mon Nov 21 09:51:56 2016 WPT: Request to import domparsing, domxpath, and innerText. BUG= 651752 , 651757 , 573309 NOTRY=true Review-Url: https://codereview.chromium.org/2516983003 Cr-Commit-Position: refs/heads/master@{#433500} [modify] https://crrev.com/63d26d050ffc4707fabaef0cac4206f8118cea45/third_party/WebKit/LayoutTests/W3CImportExpectations
,
Aug 22 2017
Bulk disowning per sshruthi's email about bug triage best practices.
,
Aug 22
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30
,
Oct 12
,
Oct 12
Things have changed since this bug was filed. The only Chrome failure in https://wpt.fyi/results/domxpath/001.html also fails in Edge. https://wpt.fyi/results/domxpath/002.html?sha=c09b8005b2 does still show a test that fails in Chrome bug passes in Firefox and Edge. It also fails in Safari though. I think issue 627682 is enough to track this.
,
Oct 12
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tkent@chromium.org
, Oct 7 2016Status: Available (was: Untriaged)