New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651754 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in sse41::blit_row_s32a_opaque

Project Member Reported by ClusterFuzz, Sep 30 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5903153625300992

Fuzzer: inferno_twister
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sse41::blit_row_s32a_opaque
  SkARGB32_Shader_Blitter::blitRect
  antifilldot8
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=342909:342958

Minimized Testcase (0.50 Kb): https://cluster-fuzz.appspot.com/download/AMIfv9503dWcs1O8TsYkagBb7yszn2VPweagCH-2DtWznFGEKcLcX9YPBWmndn33R1o0apDIimMCh2Aj_5n9nL2TmAdUk7AXWUeBvx54sqZXunfIEZixsWUlrNyCfEg10Yi6Uxw-OWltjgKXv-tS8drZ6SiNoc5dWg?testcase_id=5903153625300992

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 30 2016

Labels: M-54
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 30 2016

Labels: Pri-1

Comment 3 by kenrb@chromium.org, Sep 30 2016

Cc: bsalomon@chromium.org
Components: Internals>Skia
Owner: reed@chromium.org
Status: Assigned (was: Untriaged)
reed@: Can you please help triage this Skia security bug?

Comment 4 by aarya@google.com, Sep 30 2016

Cc: reed@chromium.org
Owner: caryclark@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 14 2016

caryclark: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 28 2016

caryclark: Uh oh! This issue still open and hasn't been updated in the last 28 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: caryclark@google.com
Owner: aarya@google.com
I'm having trouble reproducing this. I imagine there's instructions somewhere on how to see this locally. Can you point me at them?

Comment 8 by raymes@chromium.org, Nov 28 2016

Friendly ping aarya: could you ptal at comment #7? Thanks!

Comment 9 by och...@chromium.org, Nov 29 2016

Cc: -caryclark@google.com aarya@google.com
Owner: caryclark@google.com
caryclark, have you tried reproing this with a MSan build of Chrome? https://www.chromium.org/developers/testing/memorysanitizer

Looks like it still reproduces today on head.
Owner: mtklein@chromium.org
It appears that sk_msan_assert_initialized is not working as intended. Assigning to the author to shed more light.
Status: WontFix (was: Assigned)
No man, the assert's working perfectly.  When it fails it means someone way up stack (and maybe a long time ago) done screwed up.

There is no bug related to use of uninitialized memory in sse41::blit_row_s32a_opaque.

If any of you see an MSAN bug mentioing sse41::blit_row_s32a_opaque, please assign them directly to me, and I will close them with progressively more curt messages about how it's a very real problem that nevertheless has absolutely nothing to do with Skia.
Project Member

Comment 12 by ClusterFuzz, Feb 23 2017

ClusterFuzz has detected this issue as fixed in range 451968:452017.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5903153625300992

Fuzzer: inferno_twister
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sse41::blit_row_s32a_opaque
  SkARGB32_Shader_Blitter::blitRect
  antifilldot8
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=342909:342958
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=451968:452017

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv9503dWcs1O8TsYkagBb7yszn2VPweagCH-2DtWznFGEKcLcX9YPBWmndn33R1o0apDIimMCh2Aj_5n9nL2TmAdUk7AXWUeBvx54sqZXunfIEZixsWUlrNyCfEg10Yi6Uxw-OWltjgKXv-tS8drZ6SiNoc5dWg?testcase_id=5903153625300992


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment