New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment
link

Issue 651744: 15 failing web-platform-tests for DOM that pass in Firefox and Edge

Reported by foolip@chromium.org, Sep 30 2016 Project Member

Issue description

Comment 1 by foolip@chromium.org, Sep 30 2016

Blocking: 651743

Comment 2 by foolip@chromium.org, Sep 30 2016

Blocking: -651743 651572

Comment 4 by foolip@chromium.org, Sep 30 2016

Summary: 15 failing web-platform-tests for DOM that pass in Firefox and Edge (was: 12 failing web-platform-tests for DOM that pass in Firefox and Edge)

Comment 7 by bugdroid1@chromium.org, Oct 15 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b5369d478f5ef43d45ca0c7db8e48dadac35c9

commit 26b5369d478f5ef43d45ca0c7db8e48dadac35c9
Author: xing.xu <xing.xu@intel.com>
Date: Sat Oct 15 23:21:32 2016

Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is done by classStringHasClassName(const AtomicString& newClassString. If length >= 1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG= 651744 

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html

Review-Url: https://codereview.chromium.org/2402223002
Cr-Commit-Position: refs/heads/master@{#425578}

[modify] https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Element-classlist-expected.txt
[modify] https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9/third_party/WebKit/Source/core/dom/Element.cpp

Comment 8 by tkent@chromium.org, Oct 16 2016

Blockedon: 656459

Comment 9 by tkent@chromium.org, Oct 17 2016

Cc: xing...@intel.com
xing.xu@, please file new bugs when you work on a specific issue.  It makes bug duplication and launch tracking easier.

Comment 10 by tkent@chromium.org, Oct 17 2016

Blockedon: 591919

Comment 11 by tkent@chromium.org, Oct 17 2016

Blockedon: 502301

Comment 12 by tkent@chromium.org, Oct 17 2016

Blockedon: 656522

Comment 13 by bugdroid1@chromium.org, Oct 17 2016

Project Member
Labels: merge-merged-2892
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b5369d478f5ef43d45ca0c7db8e48dadac35c9

commit 26b5369d478f5ef43d45ca0c7db8e48dadac35c9
Author: xing.xu <xing.xu@intel.com>
Date: Sat Oct 15 23:21:32 2016

Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is done by classStringHasClassName(const AtomicString& newClassString. If length >= 1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG= 651744 

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html

Review-Url: https://codereview.chromium.org/2402223002
Cr-Commit-Position: refs/heads/master@{#425578}

[modify] https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Element-classlist-expected.txt
[modify] https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9/third_party/WebKit/Source/core/dom/Element.cpp

Comment 14 by xing...@intel.com, Oct 18 2016

Blockedon: 656839

Comment 15 by tkent@chromium.org, Feb 8 2017

Blockedon: 441355

Comment 16 by tkent@chromium.org, Feb 8 2017

Blockedon: 689807

Comment 17 by tkent@chromium.org, Mar 8 2017

Blockedon: 699449

Comment 18 by tkent@chromium.org, Mar 10 2017

Blockedon: 700237

Comment 19 by tkent@chromium.org, Mar 16 2017

Blockedon: 702084

Comment 20 by tkent@chromium.org, Mar 29 2017

Blockedon: 569690

Comment 21 by tkent@chromium.org, Mar 29 2017

Blockedon: 603614

Comment 22 by tkent@chromium.org, Mar 29 2017

The spreadsheet in  Issue 651572  is too old.  I created new sheet for dom/ with the latest information.

https://docs.google.com/spreadsheets/d/1-xlh6co6QYC-KVof27sVxjA7yuUFvYcaul3vE5dGHso/edit#gid=1947131581

The remaining failure are 651. 87% of it is due to  Issue 591919 .

Comment 23 by tkent@chromium.org, Apr 14 2017

Blockedon: 711562

Comment 24 by tkent@chromium.org, Apr 14 2017

Blockedon: 711568

Comment 25 by tkent@chromium.org, Apr 14 2017

Blockedon: 711575

Comment 26 by tkent@chromium.org, May 23 2017

Status: Fixed (was: Available)
All Chrome-alone failures in wpt/dom/ have been fixed!

Sign in to add a comment