New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651731 link

Starred by 2 users
Status: Verified
Owner:
nya@chromium.org
Closed: Oct 2016
Cc:
yusukes@chromium.org
█ dspaid@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

arc: Do not request Android to scan non-media files

Project Member Reported by nya@chromium.org, Sep 30 2016 
Currently ArcDownloadsWatcherService requests Android media provider to scan every new/modified files under the Downloads directory. It causes heavy load when many files are created/deleted there.

For example, on minnie, when I created 1000 *.txt files under the Downloads directory, it takes 70 seconds for MediaProvider to scan them, while they are not media files at all. During scan, most of CPU resource is consumed.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/748504fe82a72cd664eec781f844fbf086c906d1

commit 748504fe82a72cd664eec781f844fbf086c906d1
Author: nya <nya@chromium.org>
Date: Tue Oct 04 06:12:59 2016

arc: Exclude non-media files from Android media scanning.

Currently ArcDownloadsWatcherService requests Android media provider to
scan every new/modified files under the Downloads directory. It causes
heavy load when many files are created/deleted there.

This change excludes files not supported by Android media scanner.

BUG= chromium:651731 
TEST=touch a.txt  # Not scanned
TEST=touch a.png  # Scanned
TEST=unit_tests --gtest_filter='ArcDownloadsWatcherServiceTest.*'

Review-Url: https://codereview.chromium.org/2379323002
Cr-Commit-Position: refs/heads/master@{#422723}

[modify] https://crrev.com/748504fe82a72cd664eec781f844fbf086c906d1/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/748504fe82a72cd664eec781f844fbf086c906d1/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc
[modify] https://crrev.com/748504fe82a72cd664eec781f844fbf086c906d1/chrome/browser/chromeos/arc/arc_downloads_watcher_service.h
[add] https://crrev.com/748504fe82a72cd664eec781f844fbf086c906d1/chrome/browser/chromeos/arc/arc_downloads_watcher_service_unittest.cc

Comment 2 by nya@chromium.org, Oct 4 2016

Cc: yusukes@chromium.org
Labels: Merge-Request-54

Comment 3 by dimu@chromium.org, Oct 5 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 4 by nya@chromium.org, Oct 24 2016

Labels: -Hotlist-Merge-review -Merge-Review-54 M-55
Status: Fixed (was: Started)
Did not make it to M-54, but it should be included in M-55.

Comment 5 by abod...@chromium.org, Dec 9 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment